Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic Free: Restrict VideoPress access #51593

Closed
dereksmart opened this issue Mar 31, 2021 · 6 comments · Fixed by Automattic/jetpack#23189
Closed

Atomic Free: Restrict VideoPress access #51593

dereksmart opened this issue Mar 31, 2021 · 6 comments · Fixed by Automattic/jetpack#23189
Assignees
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Plan] Free [Pri] Normal Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. Triaged To be used when issues have been triaged. [Type] Task

Comments

@dereksmart
Copy link
Member

VideoPress is already blocked on the backend, but we need to reflect this properly in the Calypso UI.

What plan tier is the site on?

Free

Where are you seeing the issue?

Media > Videos

What I expected on the Atomic site

image

What actually happened

image

@dereksmart dereksmart added Atomic [Feature] VideoPress A feature to help you upload and insert videos on your site. Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. [Plan] Free labels Mar 31, 2021
@davipontesblog davipontesblog added [Type] Task Triaged To be used when issues have been triaged. labels Apr 14, 2021
@tjcafferkey tjcafferkey self-assigned this Jun 9, 2021
@tjcafferkey
Copy link
Contributor

It looks like this has since been fixed and is no longer reproducible.

@tjcafferkey
Copy link
Contributor

It looks like this has since been fixed and is no longer reproducible.

I take that back

@tjcafferkey tjcafferkey reopened this Jun 10, 2021
@tjcafferkey tjcafferkey removed their assignment Jun 15, 2021
@obenland obenland added this to the Limited Atomic milestone Jan 25, 2022
@obenland
Copy link
Member

Let's check upload_file_types to make sure that video extensions are not part of that.

@DustyReagan DustyReagan self-assigned this Jan 31, 2022
@DustyReagan
Copy link
Member

This seems to be testing correctly for me. @tjcafferkey I see this issue was marked as closed, then re-opened, is there a way to reproduce this that I missed?

Atomic Free

atomic-free

Atomic Personal

atomic-personal

Atomic Premium

atomic-premium

@DustyReagan DustyReagan removed their assignment Feb 8, 2022
@mmtr
Copy link
Member

mmtr commented Feb 8, 2022

I tested a bunch of scenarios, and everything seems to be working as expected on Calypso. However, I found some discrepancies in WP Admin.

Page Simple (Free) Atomic (Free)
wp-admin/post-new.php After inserting a Video block, both "Upload" and "Media library" buttons are disabled, so I'm unable to upload any video file. Screen Shot 2022-02-08 at 12 29 35 After inserting a Video block, both "Upload" and "Media library" buttons are enabled, so I can upload video files. Screen Shot 2022-02-08 at 12 30 11
wp-admin/upload.php The allowed file types don't include videos and I cannot upload them. Screen Shot 2022-02-08 at 12 30 53 There are no restricted file types, so I can upload video files. Screen Shot 2022-02-08 at 12 31 01

@mmtr mmtr self-assigned this Feb 8, 2022
@mmtr
Copy link
Member

mmtr commented Feb 8, 2022

Seems the discrepancy is caused by a VideoPress Free trial that has been granted to my Atomic site, which don't know if it's the intended behavior. Asked for more details in pxWta-18P-p2#comment-5423.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] VideoPress A feature to help you upload and insert videos on your site. [Plan] Free [Pri] Normal Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. Triaged To be used when issues have been triaged. [Type] Task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants