Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: stale 2FA token leads to too many API requests #5627

Closed
lsinger opened this issue May 27, 2016 · 4 comments
Closed

Me: stale 2FA token leads to too many API requests #5627

lsinger opened this issue May 27, 2016 · 4 comments
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Status] Stale [Type] Bug

Comments

@lsinger
Copy link
Contributor

lsinger commented May 27, 2016

Steps to reproduce

  1. have a stale 2FA token
  2. go to http://calypso.localhost:3000/me
  3. see the "please enter the verification code" modal
  4. open the developer console

What I expected

When we make an API request that fails because of a stale 2FA token, we wait with future requests until we have a valid token again.

What happened instead

We keep making requests for profile-links, apparently in no way throttled. This is probably not very nice to the API, and possibly also the user's bandwidth in low-bandwidth contexts.

GIF:

profile-links

@lsinger lsinger added [Type] Bug [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. labels May 27, 2016
@lancewillett
Copy link
Contributor

Good catch for both performance and UX.

@rachelmcr
Copy link
Member

rachelmcr commented Oct 31, 2016

Bug scrub: 31Oct2016

I retested this issue by deleting the twostep_auth cookie from my browser. I can reproduce the behavior described above, which also seems related to this issue with the GET /me/settings endpoint returning a 401 error when you have a stale 2FA token: #202

@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@lsinger
Copy link
Contributor Author

lsinger commented Jan 12, 2018

This isn't happening for me anymore:

stale-token

Closing.

@lsinger lsinger closed this as completed Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Status] Stale [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants