Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Block Widgets: New widgets added via widget.php are not saved #57330

Closed
mreishus opened this issue Oct 25, 2021 · 6 comments
Closed

[Bug]: Block Widgets: New widgets added via widget.php are not saved #57330

mreishus opened this issue Oct 25, 2021 · 6 comments
Labels
Block Widgets [Pri] High Address as soon as possible after BLOCKER issues Triaged To be used when issues have been triaged. [Type] Bug

Comments

@mreishus
Copy link
Contributor

mreishus commented Oct 25, 2021

Quick summary

Block Widgets: New widgets added via widget.php are not saved

Possibly related issue: #57170. However, provisional fixes we've found for this issue do not effect #57170, maybe they're not as related as they seem..

Steps to reproduce

Steps:

  • Have a simple site using the hever theme
  • Add at least one widget using the customizer
  • Visit https://[SITE].wordpress.com/wp-admin/widgets.php
  • Add a new paragraph widget, type text into it
  • Click the update button in the top right, wait for save to complete
  • Press f5 to reload.
  • The widgets page reloads and your new widget is missing.

What you expected to happen

  • The widgets page reloads and your new widget is visible.

What actually happened

  • The widgets page reloads and your new widget is missing.

Simple/Atomic

Simple

Reproducibility

Consistent

@mreishus mreishus added [Type] Bug Needs triage Ticket needs to be triaged labels Oct 25, 2021
@mreishus
Copy link
Contributor Author

D68981-code stops this issue from happening, but isn't a practical fix since it modifies core without really understanding why, or respecting the original intent of the code commented out (chesterton's fence). However, it does illustrate something is happening differently between .com and .org and might be instrumental in developing a real fix. Additionally, this may be also related to the original issue of all widgets disappearing in certain circumstances, but I'm not certain yet.

@mreishus
Copy link
Contributor Author

@david-binda Offers D68973-code which fixes the issue in my testing. The core cause is still a little bit mysterious to me.

@Robertght Robertght added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 26, 2021
@david-binda
Copy link
Contributor

I have updated the D68973-code to actually address the issue cleanly, instead of the original hacky and mysterious approach :)

@dpasque
Copy link
Contributor

dpasque commented Oct 26, 2021

Tagging @Automattic/flow-patrol-create based on issue content

@dpasque dpasque added the [Pri] High Address as soon as possible after BLOCKER issues label Oct 26, 2021
@sixhours
Copy link
Contributor

Was this fixed by D68973-code and Automattic/jetpack#21549?

@mreishus
Copy link
Contributor Author

mreishus commented Nov 1, 2021

Fixed by D69021-code

@mreishus mreishus closed this as completed Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Widgets [Pri] High Address as soon as possible after BLOCKER issues Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

5 participants