Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats: Sparkline is different between Calypso and WP Admin #57820

Open
mmtr opened this issue Nov 9, 2021 · 3 comments
Open

Stats: Sparkline is different between Calypso and WP Admin #57820

mmtr opened this issue Nov 9, 2021 · 3 comments
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Stats Everything related to our analytics product at /stats/ [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@mmtr
Copy link
Member

mmtr commented Nov 9, 2021

The stats sparkline rendered in Calypso does not fully match the one rendered in WP Admin:

Calypso WP Admin
Screen Shot 2021-11-09 at 11 25 18 Screen Shot 2021-11-09 at 11 25 24

The one in Calypso is brighter, placed in a different position, and with a slightly different size.

This happens in both Simple and (as of Automattic/jetpack#21655) in Atomic sites.

@mmtr mmtr added [Type] Bug [Feature] Stats Everything related to our analytics product at /stats/ [Pri] Low Address when resources are available. [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. Triaged To be used when issues have been triaged. labels Nov 9, 2021
@BogdanUngureanu
Copy link
Contributor

Small note, WPcom_Admin_Menu::add_stats_menu and Atomic_Admin_Menu::add_stats_menu should also rely on the same implementation as much as possible.

@mmtr
Copy link
Member Author

mmtr commented Nov 16, 2021

Small note, WPcom_Admin_Menu::add_stats_menu and Atomic_Admin_Menu::add_stats_menu should also rely on the same implementation as much as possible.

Not sure we can do much more. Stats data is on WP.com, so it's directly available for Simple sites. However, Atomic and Jetpack sites need to perform a remote request to WP.com to fetch the data. That's why the current implementation is different.

@Copons
Copy link
Contributor

Copons commented Dec 3, 2021

Added this to our Iteration 3, but it's so minor that I'd just give this a quick investigation and only act if it's a quick win.

My hunch is that it'd be easier to make the Calypso version look like the wp-admin one, but it might be my front-end bias speaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Stats Everything related to our analytics product at /stats/ [Pri] Low Address when resources are available. Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants