Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Move components and libs to shared/ #656

Closed
11 of 27 tasks
hoverduck opened this issue Nov 24, 2015 · 1 comment
Closed
11 of 27 tasks

Framework: Move components and libs to shared/ #656

hoverduck opened this issue Nov 24, 2015 · 1 comment
Labels
Framework Server Side Rendering [Type] Task
Milestone
Themes: Showcase ...

Comments

@hoverduck
Copy link
Contributor

We are going to need a couple of components as well as stuff from client/lib for server-side rendering, some of which are fortunately already independent of the DOM/BOM, while others will need tweaking. Starting a list:

  • components/data/store-connection
  • components/data/screen-title
  • my-sites/empty-content (related to 10207-gh-calypso-pre-oss)

No DOM/BOM dependencies:

  • EmptyContent
  • Gridicon
  • lib/url
  • Card
  • Dispatcher
  • emitter

Themes related:

  • Theme
  • ThemesList
  • ThemesListFetcher
  • lib/themes to shared/
  • my-sites/themes to shared/

Components that depend on the BOM/DOM in some way, and need to be looked at more closely (and maybe modified) when we move them:-

  • interpolate-components
  • lib/warn
  • components/search
  • SelectDropdown
  • SectionNav
  • StickyPanel
  • InfiniteList
  • lib/mixins/i18n
  • viewport
  • UrlSearch
  • Popover
  • analytics
  • config
@ehg
Copy link
Member

ehg commented Dec 15, 2015

Closing, as we're getting rid of the shared directory. #1594

@ehg ehg closed this as completed Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Server Side Rendering [Type] Task
Projects
None yet
Milestone
Themes: Showcase M3-LoggedOut
Development

No branches or pull requests
2 participants
@ehg @hoverduck