Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE: Unusable Editor on Themes with Custom Background Color #71679

Closed
carinapilar opened this issue Jan 4, 2023 · 12 comments
Closed

FSE: Unusable Editor on Themes with Custom Background Color #71679

carinapilar opened this issue Jan 4, 2023 · 12 comments
Labels
[Pri] High [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@carinapilar
Copy link

carinapilar commented Jan 4, 2023

Quick summary

It seems that the new editor isn't loading custom background colors from themes, so depending on the theme you have on the site, you aren't able to see the content in the editor.

Steps to reproduce

  1. Activate a theme that has a dark background color, and light text color (examples I tried: Remote, Geologist, Skatepark, etc).
  2. After activating the theme, go to Appearance > Editor.

What you expected to happen

To see the editor with the same content you see on the live site.

What actually happened

It's not loading the background color, so you can't really see the text in light color to edit the content.

Context

Found this when helping a user today, and was able to replicate this on 2 of my Simple test sites.

With the Remote theme for example, this is what I have on the live site:

remote-live-site

And this is how it loads in the editor:

remote-on-fse

Browser, operating system and other notes

Was able to replicate the issue on Chrome and Firefox, on macOS.

Reproducibility

Consistent

Severity

All

Available workarounds?

No, but the platform is still usable.

@carinapilar carinapilar added [Type] Bug [Pri] High User Report This issue was created following a WordPress customer report labels Jan 4, 2023
@noahtallen
Copy link
Contributor

noahtallen commented Jan 4, 2023

We can definitely reproduce this on new sites with the editor. Interestingly, this does not happen while sandboxed. As a result, we think there are two issues:

  1. The implementation in Gutenberg relies on the load-order of CSS for specificity, which is a really fragile practice, and easily breaks.
  2. The minifier on dotcom somehow changes the load order so that the white style is higher specificity than others, breaking it for simple sites. (This is why the issue wasn't caught in Gutenberg originally, since they did test this scenario)

Our thought for now is to delete the broken line of code on dotcom, since the issue it was fixing doesn't apply to all/most of our themes. We also think this could be contained to just simple sites, though we'll need to test that.

A proper fix is on the way in Gutenberg, though it won't be available for a week or two most likely: https://github.com/WordPress/gutenberg/pull/46752/files#r1055807165

@noahtallen
Copy link
Contributor

This should be hotfixed for simple sites now. (see D97057-code)

@Gustavo-Hilario
Copy link

There is another report about this issue on an AT site: 5840151-zen

The background of the site is black on the live site. For a few milliseconds, it is black on the Site Editor, but then it becomes white. This seems to be the CSS code that is causing the issue:

Annotation on 2023-01-05 at 12-22-55

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 5840151-zen
  • 5848623-zen
  • 5848682-zen
  • 5856827-zen

@noahtallen
Copy link
Contributor

Same issue, then :/

This one can't be hotfixed, but hopefully we can get a patch release soon.

If I'm not mistaken, this issue is more intermittent on Atomic, right? (I did test yesterday and didn't reproduce)

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Jan 7, 2023

If I'm not mistaken, this issue is more intermittent on Atomic, right?

Yeah. It is intermittent on Atomic. I also can't reproduce this issue on my end. However, yesterday, I also noticed this issue on another AT site here: 38939383-hc ( Munchies. The user didn't notice this because their background is a light yellow)

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Jan 8, 2023

Another report here: 37815582-hc (Atomic Site – Theme: Munchies)

@cuemarie
Copy link

cuemarie commented Jan 8, 2023

Another AT site: 35421353-hc on Theme: Quadrat

  • 5848623-zd-woothemes follow up when this is resolved would be appreciated.

As a workaround, I helped them move the content on their Home template onto their home page via post content block, so they can edit most of their front page via the page editor for now.

@alliebbush2
Copy link

AT Site-5848682-zd Theme: Disco
5848682-zd- follow up when this is resolved would be appreciated.

@noahtallen
Copy link
Contributor

We are hoping that the Gutenberg v14.9.1 release will fix this issue, which should be on Atomic tomorrow.

@synora
Copy link
Contributor

synora commented Jan 11, 2023

Another report came in at 5856827-zd. The theme is Appleton, site is Atomic, and I can replicate it.
Happy to hear that a fix is in the works!

@noahtallen
Copy link
Contributor

I think this fix should be live now. Of course, please re-open if there are more reports!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

6 participants