Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separator Block - Default Style is Identical to Wide Style on some FSE themes #76903

Open
masperber opened this issue May 13, 2023 · 4 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Platform] Simple [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@masperber
Copy link

Quick summary

The Seperator Block has 3 supported styles: Default (narrow line), Wide (wide line), and Dotted (dotted line)

On some (perhaps all) FSE themes, the Default style is identical to the Wide style.

Steps to reproduce

  1. Start a site with an FSE theme. (I have verified this on Twenty Twenty Three and Bitácora.)
  2. Add a Separator Block in any location.
  3. Observe that the Default style is identical to the Wide style.

What you expected to happen

The Default style should be narrower than the Wide style. (I have verified this works properly on the Hever theme.)

What actually happened

The Default style is identical to the Wide style.

Impact

All

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

Identified workaround:

This CSS snippet should change the width of default style Separator, but verify that the


has the .is-style-default class before applying it:

.wp-block-separator.is-style-default {
	width: 50vw;
}
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] High Address as soon as possible after BLOCKER issues labels May 13, 2023
@masperber
Copy link
Author

Initial customer report: 6286176-zen

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 6286176-zen

@karenroldan karenroldan added [Pri] Low Address when resources are available. and removed [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels May 15, 2023
@cuemarie
Copy link

cuemarie commented May 16, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated on themes Blank Canvas and Twenty Twenty-Three on both WordPress.com and self-hosted sites.
  • Theme Twenty Twenty-Two does not show the same issue.

Screenshots/Recordings

Editor, Self-Hosted Site
Markup on 2023-05-16 at 09:50:47

Live Site, Self-Hosted Site
Markup on 2023-05-16 at 09:51:12

Workaround

In order for this CSS to work, a user must select "Default" in the styles selection of the block, even though "Default" is selected by default. This adds the .is-style-default class to the element.

Further, the 50vw may not work, depending on the theme, but the units can be updated as needed in that case.

📌 ACTIONS

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Platform] Simple [Platform] Atomic labels May 16, 2023
@sophiegyo
Copy link

I noticed this on Wooni as well, which is, well, a P2 (and therefore not FSE).

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label May 23, 2024
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Platform] Atomic [Platform] Simple [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

5 participants