Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Replace Template Part option missing from List View Options if block not selected #77280

Closed
csabarakasz opened this issue May 23, 2023 · 6 comments
Labels
[Feature] Full Site Editor The site editor. [Platform] Atomic [Platform] Simple [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@csabarakasz
Copy link

Quick summary

When I want to replace a Header Template Part in the Site Editor, the replace header option only shows up in the floating menu, not in the List View.

Steps to reproduce

  1. Click List View > three dots next to Header:

dgw2X8UnU3buRZtK7Zw8emcxewpY09CiJWtpPY0X.jpg

  1. Click List View > Select the Header > click the three dots from the floating menu > Replace Header options is there:

M6vdHm30kgHT6iIEUa4RV8SKpPMzFTincSXLmi72.jpg

If I remember correctly, it used to be there at both places.

What you expected to happen

The option would show up at both block setting menu.

What actually happened

Only show up on the floating menu.

Impact

All

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

In Gutenberg 15.8 the Block Settings menu was rearranged. I wonder if it is connected

@csabarakasz
Copy link
Author

Sharing again to link the two GitHub links. I wonder if this is related: WordPress/gutenberg#50453

@csabarakasz csabarakasz changed the title Site Editor: Replace Header option only shows up from the floating menu Site Editor: Replace Header option only shows up in the floating menu May 23, 2023
@csabarakasz
Copy link
Author

Ps.: there are also two Edit buttons in the floating menu 🤷‍♂️ 😆

@github-actions github-actions bot added [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels May 23, 2023
@cuemarie
Copy link

cuemarie commented May 24, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • My tests show that Replace Header appears in the List View menu as well, but only if you've selected the Header template part. If you have something else selected, then click the ... button next to the Header Template Part in List View, Create Reusable Block appears instead of "Replace Header".

Screenshots/Recordings

XrAWVC.mp4

Test Sites:

Atomic Site

  • WordPress 6.2.2
  • Gutenberg v15.8.1
  • Theme Twenty Twenty-Three 1.1

Simple (Edge) Site

  • WordPress 6.2+ (not able to see exact version as this is a simple site)
  • Gutenberg: v15.8.1
  • Theme Twenty Twenty Three

Outside of DotCom

  • WordPress 6.2.2
  • Gutenberg v15.8.1
  • Theme: Twenty Twenty-Three

📌 ACTIONS

@cuemarie cuemarie changed the title Site Editor: Replace Header option only shows up in the floating menu Site Editor: Replace Template Part option missing from List View Options if block not selected May 24, 2023
@cuemarie
Copy link

cuemarie commented May 24, 2023

Ps.: there are also two Edit buttons in the floating menu 🤷‍♂️ 😆

@csabarakasz as this is a different issue, it should be reported separately rather than in the comments here. I've created this report:

@cuemarie cuemarie added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Feature] Full Site Editor The site editor. and removed Needs triage Ticket needs to be triaged labels May 24, 2023
@cuemarie
Copy link

cuemarie commented Jun 1, 2023

This comment provides some good insight into the underlying issue here. This issue may remain for the time being, as it's a bit more complicated and less impactful than other issues in the works at the moment.

@cuemarie cuemarie added [Pri] Low Address when resources are available. and removed [Pri] Normal Schedule for the next available opportuinity. labels Jun 1, 2023
@annezazu
Copy link

I can't replicate this using WP 6.6.1 and GB 19.0:

Screen.Recording.2024-08-29.at.3.21.59.PM.mov

I'm also not seeing any recent reports here. Happy to reopen and have folks investigate if we can get more up to date steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Platform] Atomic [Platform] Simple [Pri] Low Address when resources are available. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants