-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Preview: Save & Activate button separation #81119
Comments
Support References This comment is automatically generated. Please do not edit it.
|
See slack discussion p1701229602194299-slack-CRWCHQGUB, there are some quite complex product decisions that need to be made around this issue. |
Summarizing the concerns of potential complexities:
Based on the above points, I'd propose we deprioritize this issue. The current behavior is already clear, if we think the BTP as a truly "Preview" experience (quoting @autumnfjeld's words). We also have communicated this behavior clearly in two places: |
In relation to our current discussion, I'm sharing @tanjoymor's insight about "saving without activating", which comes with caveats that are a big learning curve. Understanding these aspects might be essential as we consider implementing or refining it in the future. pdtkmj-1JP-p2#comment-3235 The preview allows them to see it, but it may not look entirely right without some adjustments. Making adjustments can be slow for some users and they will want to save and continue later. It would be excellent if we can answer and explain: "Yes you can! With the Live Preview you can view your site using different themes, with a few caveats, and you can save your changes to come back to it later. So long as you save without activating, your live site won't be affected." This really is a game changer in the realm of switching themes. But it might worth noting that the caveats are kinda big and important, albeit mostly educational, and I'm not sure what thoughts there have been on these:
The three key points here are:
It's an educational issue more than anything. I don't think any of it is a blocker for the feature. But I do think they're points that we should all be aware of, try to mitigate as much as we can, and make sure HEs are broadly aware. One other piece for a future project (maybe core?) is to be able to transfer "template parts" between themes. So that when someone does have a custom designed header/footer they want to keep, they don't have to fiddle with trying to copy it over or redesigning it. |
I think separating the save and activate actions will complicate it more. Maybe we could try the following to simplify and unify the UX:
|
@miksansegundo Actually, right now all buttons are already unified as "Activate & Save":
So I think we're fine now 😄 |
(And they are just "Activate" if there user has not done any customization.) |
I still think that the "Save" part in "Activate & Save" sounds redundant and less clear than just "Activate", because that's the goal of the feature. Anyways, just an opinion 🙂 Another thing, I remember reading feedback saying that "Save & Activate" makes more sense than "Activate & Save". I agree with this too. |
Description
Currently, saving changes and activating the theme cannot be done separately during the Live Preview, they must be done at the same time. So, it’d be good to have the Save and Activate separation.
There was some feedback about this;
Acceptance Criteria
Dev Tasks
We have already covered this topic in https://github.com/Automattic/dotcom-forge/issues/2391#issuecomment-1624765146, and I personally think the following specification is sufficient.
Related
The text was updated successfully, but these errors were encountered: