Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF Embeds Not Working on Classic Themes #85244

Closed
kelasante opened this issue Dec 13, 2023 · 23 comments
Closed

PDF Embeds Not Working on Classic Themes #85244

kelasante opened this issue Dec 13, 2023 · 23 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@kelasante
Copy link
Collaborator

Quick summary

PDF embeds do not show inline embeds on live sites. It shows in the Editor but not in the preview or published page.

Steps to reproduce

  1. Add a PDF to a simple site using File block.
  2. Enable "show inline embed" in block settings

What you expected to happen

PDF shows in Editor and Live Site

What actually happened

PDF shows only in the Editor and not on the live site.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@kelasante kelasante added [Type] Bug Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Dec 13, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Simple [Pri] High labels Dec 13, 2023
@kelasante
Copy link
Collaborator Author

Issue was reported in 7448330-zen

Copy link

github-actions bot commented Dec 14, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • 7448330-zen
  • 7467104-zen
  • 7469540-zen
  • 7463738-zen
  • 7473833-zen
  • 7467231-zen
  • 7486167-zen
  • -zen
  • 7489159-zen
  • 7482639-zen
  • 7505106-zen
  • 7504998-zen
  • 7458612-zen
  • 7464568-zen
  • 7471698-zen
  • 7449298-zen
  • 7496224-zen
  • 7522039-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 14, 2023
@ai2n
Copy link

ai2n commented Dec 18, 2023

Might impact atomic too. 7467104-zen

@OmarFPG
Copy link

OmarFPG commented Dec 19, 2023

7469540-zen, since this is a business user, I've suggested a plugin as a temporary workaround.
7463738-zen, Premium plan, no plugin workaround at hand. But the PDF embed shows a link to the file, which is viewable, at least.

@OmarFPG
Copy link

OmarFPG commented Dec 19, 2023

7473833-zen, another premium user, no plugin workaround.

@liviopv
Copy link

liviopv commented Dec 20, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Could Not Replicate
  • Tested on Atomic – Could Not Replicate
  • Replicable outside of Dotcom – No

📌 FINDINGS/SCREENSHOTS/VIDEO
Chrome for Mac
CleanShot 2023-12-20 at 11 55 35@2x

Firefox for Mac

CleanShot 2023-12-20 at 11 57 16@2x

Safari for Mac

CleanShot 2023-12-20 at 11 58 57@2x

📌 ACTIONS

  • Triaged
  • Requested author feedback
  • Closed as could not replicate (please reopen if the issue reoccurs)

📌 Message to Author
@kelasante @OmarFPG I was not able to reproduce, as seen in the screenshots above.

Please collect the browser info from the users you interacted with and reopen the issue as needed.

@liviopv liviopv closed this as completed Dec 20, 2023
@liviopv liviopv added the [Closed] Not Reproducible Issue cannot be reproduced. label Dec 20, 2023
@OmarFPG
Copy link

OmarFPG commented Dec 20, 2023

Thanks, @liviopv. I tried adding new PDF embeds, and they're working now; however, I'm not seeing them yet on the customers' sites. I'll ask them to try removing them and adding them again.

@kelasante
Copy link
Collaborator Author

Thanks! @liviopv it is still not working on my test site, https://nogymhero.wordpress.com/pdf-test/ (Chrome 120, OS Sonoma)

This is how it looks like in the Editor:
Markup 2023-12-20 at 17 08 12

And this is how it looks on live site:

Markup 2023-12-20 at 17 10 58

@kelasante kelasante reopened this Dec 21, 2023
@jp-imagines
Copy link

Just came across this in 7467231-zd-a8c (related to 7467104-zd-a8c – comment above updated for proper ID), and I'm still able to replicate the issue on this user's site. However, I don't see the issue on @kelasante 's test page above.

On the user's site, the object element for the embedded PDF file exists, but it has a hidden property which forcefully hides it.

JXoZIv.png

That looks to be coming directly from their theme (Maywood). If I preview that theme on @kelasante 's site, I see the same hidden property and behavior. This might be a theme-specific issue?

@Mfarroq1
Copy link

7486167-zen The issue only appears in the classic themes, In block themes pdf working fine

@kelasante
Copy link
Collaborator Author

Just came across this in 7467231-zd-a8c (related to 7467104-zd-a8c – comment above updated for proper ID), and I'm still able to replicate the issue on this user's site. However, I don't see the issue on @kelasante 's test page above.

On the user's site, the object element for the embedded PDF file exists, but it has a hidden property which forcefully hides it.

JXoZIv.png

That looks to be coming directly from their theme (Maywood). If I preview that theme on @kelasante 's site, I see the same hidden property and behavior. This might be a theme-specific issue?

When I created the test page, I had the Hever theme but switched it to Twenty Twenty-Two yesterday. That seems to be why it was not working yesterday and works today per @Mfarroq1 comment. I'll follow up with the user 7448330/zen who initially reported this and share workaround of switching to a block theme.

@kelasante kelasante changed the title PDF Embeds Not Working on Simple Sites PDF Embeds Not Working on Classic Themes Dec 22, 2023
@jp-imagines
Copy link

@kelasante Some CSS should do the trick as a temporary workaround if they're uninterested in changing themes:

/* Workaround: Display embedded PDFs | xxx-zd JP */
.wp-block-file > object.wp-block-file__embed[hidden] {
    display: unset;
}

@kelasante
Copy link
Collaborator Author

@kelasante Some CSS should do the trick as a temporary workaround if they're uninterested in changing themes:

/* Workaround: Display embedded PDFs | xxx-zd JP */
.wp-block-file > object.wp-block-file__embed[hidden] {
    display: unset;
}

Thank you @jp-imagines That CSS did the trick! 😄

@mgozdis
Copy link

mgozdis commented Dec 22, 2023

Another user report here but they are AT: 7489159-zd-a8c

I thought it was this bug, which was closed, but it's affecting all browsers now and not just Safari.

Deactivating Gutenberg is another workaround if site is AT.

@Aurorum
Copy link
Contributor

Aurorum commented Dec 24, 2023

7482639-zen (provided workaround)

@sophiegyo
Copy link

Encountered in 7505106-zen (and related 7504998-zen). Provided workaround, including an adjustment to try to stop the preview working on iOS devices because of this issue:
https://developer.apple.com/forums/thread/649982

@github-actions github-actions bot added the [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. label Dec 28, 2023
@liviopv
Copy link

liviopv commented Dec 28, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated / Could Not Replicate / Uncertain
  • Tested on P2 (optional) – Replicated / Could Not Replicate / Uncertain
  • Replicable outside of Dotcom – No

📌 FINDINGS/SCREENSHOTS/VIDEO
Simple Site, Twenty Sixteen Theme
CleanShot 2023-12-28 at 11 09 44@2x

Also reproduced in a local site and reported in core: WordPress/gutenberg#57419

📌 ACTIONS

  • Triaged

📌 Message to Author
Thanks for reopening @kelasante

@liviopv liviopv added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Dec 28, 2023
@liviopv
Copy link

liviopv commented Dec 28, 2023

Moving interactions from duplicate issue

  • 7458612-zd-a8c
  • 7464568-zd-a8c
  • 7471698-zd-a8c
  • 7486167-zd-a8c
  • 7449298-zd-a8c

@liviopv liviopv removed the [Closed] Not Reproducible Issue cannot be reproduced. label Dec 28, 2023
@darnelldibbles
Copy link

@saginpj
Copy link

saginpj commented Dec 29, 2023

  • 7496224-zen (provided workaround)

@sophiegyo
Copy link

User report 7522039-zen

Theme: Exford (Varia)
Plan: Personal - can't use CSS workaround

@saginpj
Copy link

saginpj commented Jan 6, 2024

  • 7542307 - zen
  • 7573280 - zen (provided CSS workaround)

@liviopv
Copy link

liviopv commented Jan 25, 2024

I can no longer reproduce, I think it was fixed with WordPress/gutenberg#57396 closing

@liviopv liviopv closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Interaction #] > 10 (Automated) interaction count label for better visibility. Please don't add these manualliy. [Platform] Simple [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests