Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'Expand on Click' functionality of the image block is not working on websites that use the classic theme (not the block theme). #85638

Closed
saginpj opened this issue Dec 21, 2023 · 15 comments
Closed

The 'Expand on Click' functionality of the image block is not working on websites that use the classic theme (not the block theme). #85638

saginpj opened this issue Dec 21, 2023 · 15 comments
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@saginpj
Copy link

saginpj commented Dec 21, 2023

Quick summary

The "Expand on Click" functionality is not working for image blocks that have classic themes. However, it works fine on block themes.

Steps to reproduce

  1. Install any classic theme, such as Twenty Seventeen or Twenty Fourteen.
  2. Open the page/post editor.
  3. Add images using the image block and enable the "expand on click" option.
  4. Publish the page/post.
  5. Visit the page using Chrome, Firefox, or Edge (latest version).
  6. Click the image, but the image will not expand.

What you expected to happen

block-theme-expand-image

What actually happened

classic-theme-expand-image

Impact

Some (< 50%)

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

No response
@saginpj saginpj added [Type] Bug Needs triage Ticket needs to be triaged labels Dec 21, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] BLOCKER labels Dec 21, 2023
@saginpj
Copy link
Author

saginpj commented Dec 21, 2023

  • 7482764 - zen

@tvolpert tvolpert mentioned this issue Dec 22, 2023
Closed
@tvolpert
Copy link

reported in 7488884-zen

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 22, 2023 •
edited
Loading

Support References

This comment is automatically generated. Please do not edit it.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 22, 2023
@liviopv liviopv added [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. and removed [Pri] BLOCKER labels Dec 26, 2023
@liviopv
Copy link

liviopv commented Dec 26, 2023

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Tested on Atomic with T17 with GB 17.2.3 Jetpack Carousel module turned off - replicated
  • Tested on Atomic with T17 with GB 17.2.3 Jetpack Carousel module turned on - replicated
CleanShot.2023-12-26.at.09.27.46.mp4
  • Tested on Simple with T16 GB 17.2.3 - replicated
CleanShot.2023-12-26.at.09.30.35.mp4

📌 ACTIONS

cc @Automattic/frontity

@krutidugade
Copy link

Expand on click doesn't work with other themes as well. I have tested on Mayland theme.

Reported here: 7485749
Theme: Mayland

@liviopv liviopv added Triaged To be used when issues have been triaged. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. and removed Needs triage Ticket needs to be triaged labels Dec 26, 2023
@liviopv
Copy link

liviopv commented Dec 27, 2023

Moving interactions from Automattic/themes#7561

@cbravobernal cbravobernal mentioned this issue Dec 27, 2023
Merged
@sirreal
Copy link
Member

sirreal commented Dec 27, 2023

This should be fixed in Gutenberg 17.4 by WordPress/gutenberg#57396.

@Mfarroq1
Copy link

7482764-zen

@supernovia
Copy link
Contributor

We have several cases in this forums thread:
https://wordpress.com/forums/topic/expand-on-click/

@saginpj
Copy link
Author

saginpj commented Jan 6, 2024 •
edited
Loading

@liviopv
Copy link

liviopv commented Jan 25, 2024

Marking this one as fixed based on WordPress/gutenberg#57396

@liviopv liviopv closed this as completed Jan 25, 2024
@liviopv liviopv added the [Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. label Jan 25, 2024
@nicolynramos
Copy link

Received another report and was able to reproduce on testing site with classic themes.

7688476-zen

@nicolynramos nicolynramos reopened this Feb 7, 2024
@cbravobernal
Copy link

This should be fixed by
WordPress/gutenberg#58818

@cbravobernal
Copy link

I released a Gutenberg version with the fix.
https://github.com/WordPress/gutenberg/releases/tag/v17.6.5

@mrfoxtalbot
Copy link

I can confirm is fixed. I am going going to close this one but I will cross-link a related issue: #89564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Closed] Fixed Issues explicitly fixed with PRs. Do not use for no longer reproducible issues. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Pri] High [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
10 participants
@sirreal @supernovia @mrfoxtalbot @liviopv @saginpj @krutidugade @tvolpert @cbravobernal @nicolynramos @Mfarroq1