-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Settings: Add notices for (de)activating Jetpack modules #10583
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
a7481c3
Notices: Add notice handler and config for Jetpack module activation
tyxla db9de09
Notices: Add Jetpack module activation notices to middleware
tyxla 2038605
Notices: Update (de)activation messages for Jetpack modules
tyxla b8ae80f
Notices: Update default (de)activation messages for Jetpack modules
tyxla File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { translate } from 'i18n-calypso'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { | ||
JETPACK_MODULE_ACTIVATE_FAILURE as ACTIVATE_FAILURE, | ||
JETPACK_MODULE_ACTIVATE_SUCCESS as ACTIVATE_SUCCESS, | ||
JETPACK_MODULE_DEACTIVATE_FAILURE as DEACTIVATE_FAILURE, | ||
JETPACK_MODULE_DEACTIVATE_SUCCESS as DEACTIVATE_SUCCESS, | ||
} from 'state/action-types'; | ||
|
||
export const MODULE_NOTICES = { | ||
'infinite-scroll': { | ||
[ ACTIVATE_SUCCESS ]: translate( 'Infinite scroll is now on.' ), | ||
[ DEACTIVATE_SUCCESS ]: translate( 'Infinite scroll is now off.' ), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternate string suggestion:
|
||
[ ACTIVATE_FAILURE ]: translate( 'Infinite scroll could not be switched on.' ), | ||
[ DEACTIVATE_FAILURE ]: translate( 'Infinite scroll could not be switched off.' ), | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
/** | ||
* External dependencies | ||
*/ | ||
import { translate } from 'i18n-calypso'; | ||
|
||
/** | ||
* Internal dependencies | ||
*/ | ||
import { | ||
JETPACK_MODULE_ACTIVATE_FAILURE, | ||
JETPACK_MODULE_ACTIVATE_SUCCESS, | ||
JETPACK_MODULE_DEACTIVATE_FAILURE, | ||
JETPACK_MODULE_DEACTIVATE_SUCCESS, | ||
} from 'state/action-types'; | ||
import { MODULE_NOTICES } from './constants'; | ||
import { successNotice, errorNotice } from 'state/notices/actions'; | ||
|
||
export const onJetpackModuleActivationActionMessage = ( dispatch, { type, moduleSlug } ) => { | ||
const noticeSettings = { duration: 10000 }; | ||
let message = MODULE_NOTICES[ moduleSlug ] && MODULE_NOTICES[ moduleSlug ][ type ]; | ||
let messageType; | ||
|
||
switch ( type ) { | ||
case JETPACK_MODULE_ACTIVATE_SUCCESS: | ||
message = message || translate( 'Turned on successfully.' ); | ||
messageType = 'success'; | ||
break; | ||
case JETPACK_MODULE_DEACTIVATE_SUCCESS: | ||
message = message || translate( 'Turned off successfully.' ); | ||
messageType = 'success'; | ||
break; | ||
case JETPACK_MODULE_ACTIVATE_FAILURE: | ||
message = message || translate( 'An error occurred during activation.' ); | ||
messageType = 'error'; | ||
break; | ||
case JETPACK_MODULE_DEACTIVATE_FAILURE: | ||
message = message || translate( 'An error occurred during deactivation.' ); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Alternate string suggestion:
|
||
messageType = 'error'; | ||
break; | ||
} | ||
|
||
if ( ! message ) { | ||
return; | ||
} | ||
|
||
if ( messageType === 'success' ) { | ||
dispatch( successNotice( message, noticeSettings ) ); | ||
} else if ( messageType === 'error' ) { | ||
dispatch( errorNotice( message, noticeSettings ) ); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternate string suggestion:
translate( 'Scroll Infinitely' )
— translations: 25. ES Score: 4.27PR translation status page