Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media section: tiding secondary actions #11770

Merged
merged 2 commits into from
Mar 6, 2017
Merged

Media section: tiding secondary actions #11770

merged 2 commits into from
Mar 6, 2017

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Mar 4, 2017 •
edited
Loading

IMPORTANT

This PR is part of a set of PRs. Take a look to #11667, Pull requests section, to know to right order to review.

This PR is targeting to try/media-section-v2.

This PR is just for janitorial purposes. Re writes secondary-actions in ES6, add translate helper, etc.

@retrofox retrofox added [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Mar 4, 2017
@retrofox retrofox requested a review from gwwar March 4, 2017 14:09
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/secondary-actions-tidy

@matticbot matticbot added the [Size] M Medium sized issue label Mar 4, 2017
@artpi artpi mentioned this pull request Mar 4, 2017
Closed
4 tasks
@retrofox retrofox changed the title Media section: tyding secondary actions Media section: tiding secondary actions Mar 4, 2017
@artpi artpi force-pushed the try/media-section-v2 branch from 7791f0f to a343b88 Compare March 6, 2017 16:37
@retrofox retrofox force-pushed the update/secondary-actions-tidy branch from 9405901 to df21607 Compare March 6, 2017 18:37
@matticbot matticbot added the [Size] M Medium sized issue label Mar 6, 2017
gwwar
gwwar approved these changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 6, 2017
@retrofox retrofox merged commit e3c3da7 into try/media-section-v2 Mar 6, 2017
@retrofox retrofox deleted the update/secondary-actions-tidy branch March 6, 2017 19:29
@retrofox retrofox mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwwar gwwar gwwar approved these changes

Assignees
No one assigned
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Size] M Medium sized issue [Type] Janitorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@retrofox @matticbot @gwwar