Framework: <GlobalNotices> visual design update #1415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add scss file. - Update references. - Tweak settings messaging when saving.
mtias
added
Framework
[Status] In Progress
[Status] Needs Design Review
|
Will this pill share styles/code with the Reader 'new posts' thing? Or will we refactor that later to use this? They also look a little bit tall–my mockup had them at 34px tall, not sure where that number came from, but I think we could do 36 or 40. Yours appears to be 50? |
scottsweb
added
[Status] Needs Design Review
|
@rickybanister for sure, feel free to tweak the styling directly here, I forgot to push it before. |
| @@ -110,7 +110,7 @@ module.exports = React.createClass( { | |||
| </Welcome> | |||
| <InviteMessage sites={ this.props.sites }/> | |||
| <EmailVerificationNotice user={ this.props.user } /> | |||
| <NoticesList id="notices" notices={ notices.list } forcePinned={ 'post' === this.state.section } /> | |||
There was a problem hiding this comment.
We need both of these components alive for now
Moving from old notices to new will take A LOT of time, because it involves connecting every component that sends a notice and is impossible to do in one PR
So I propose for the time beeing not touching notices-list and introducing them side by side.
There was a problem hiding this comment.
We can also try to rewrite this new GlobalNotice component to pull and merge data both from old notices data store and new redux store.
This will probably be the best approach
There was a problem hiding this comment.
I'm not really touching notices-list, just renaming, cleaning up the is-pinned attribute (since the new design will always be pinned).
artpi
added a commit
that referenced
this pull request
Dec 15, 2015
artpi
added a commit
that referenced
this pull request
Dec 15, 2015
Global notices to proper component Notices: Move action types to common file Notices: Move global notices to /ui store tree Notices: Move global notices according to design in #1415 Notices: fix file address
artpi
added a commit
that referenced
this pull request
Dec 16, 2015
Global notices to proper component Notices: Move action types to common file Notices: Move global notices to /ui store tree Notices: Move global notices according to design in #1415 Notices: fix file address
artpi
added a commit
that referenced
this pull request
Dec 17, 2015
Notices: Move store to proper place in tree, Global notices to proper component Notices: Move action types to common file Notices: Move global notices to /ui store tree Notices: Move global notices according to design in #1415 Notices: fix file address Notices: Reduxification actions, dispatching Notices: Reduxification proper actions dispatching Notices: connect layouts to global state Notices: Connect global-notices component Notices: Repair pulsing dot Notices: Proper action types Notices: Change Provider argument because of React 0.14 Provider now takes react component instead of function Notices: Change layoutComponent to layoutElement in accordance with naming scheme Notices: Remove extra space Notices: Var to let Notices: Reduxification: null instead of noop in connect Notices: Reduxification - remove use of lodash from notice reducer Notices: Change attaching of provider to React 0.14 format Notices: Reduxifications change notice payload Notices: Reduxification: create action for setSection Notices: Reduxification change noSidebar to hasSidebar Notices: Reduxification - use proper thunk middleware for timeout Remove helper from notices actions Notices: Reduxification - move notices from ui to top level in store
artpi
added a commit
that referenced
this pull request
Dec 22, 2015
Notices: Move store to proper place in tree, Global notices to proper component Notices: Move action types to common file Notices: Move global notices to /ui store tree Notices: Move global notices according to design in #1415 Notices: fix file address Notices: Reduxification actions, dispatching Notices: Reduxification proper actions dispatching Notices: connect layouts to global state Notices: Connect global-notices component Notices: Repair pulsing dot Notices: Proper action types Notices: Change Provider argument because of React 0.14 Provider now takes react component instead of function Notices: Change layoutComponent to layoutElement in accordance with naming scheme Notices: Remove extra space Notices: Var to let Notices: Reduxification: null instead of noop in connect Notices: Reduxification - remove use of lodash from notice reducer Notices: Change attaching of provider to React 0.14 format Notices: Reduxifications change notice payload Notices: Reduxification: create action for setSection Notices: Reduxification change noSidebar to hasSidebar Notices: Reduxification - use proper thunk middleware for timeout Remove helper from notices actions Notices: Reduxification - move notices from ui to top level in store
|
This has been replaced by the more up-to-date #2413 |
lancewillett
removed
the
[Status] Needs Design Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in-progress work finalizes the component cleanup of notices-list, with
components/global-noticesused inlayout. It adjusts the design to the pill-shape notices. It still usesnoticeas the core component.