Editor redux: passing IDs to action creators & Washing machine madness #3547
Conversation
artpi
added
[Status] In Progress
[Status] Needs Review
| @@ -39,6 +42,8 @@ const EditorTitle = React.createClass( { | |||
|
|
|||
| getDefaultProps() { | |||
| return { | |||
| siteId: 0, | |||
There was a problem hiding this comment.
Why is the default siteId 0?
There was a problem hiding this comment.
So it's not any valid siteId?
You are for null ? I always have trouble deciding... :/
|
👍 Looking good so far. Ping me again when you're ready for another review. |
| } | ||
|
|
||
| export function getCurrentEditedPostId( state ) { | ||
| return state.ui.editor.post.currentEditedPostId; |
There was a problem hiding this comment.
We should probably move this selector to be alongside state/ui/editor/post. Edit: hmm, looks like we're grouping all of these at the top level.
There was a problem hiding this comment.
Yeah, I assume this tree will be trimmed and shaped a lot.
I wanted to keep it at top level so we dont have to edit files that import this selector while we toss and turn tree structure.
|
@aduth: this PR should be around ready, but needs heavy testing. I will try to find time for it during the support rotation. |
|
There are some failing tests here. |
| @@ -16,6 +16,7 @@ export const EDITOR_CONTACT_FORM_ADD_DEFAULT_FIELD = 'EDITOR_CONTACT_FORM_ADD_DE | |||
| export const EDITOR_CONTACT_FORM_CLEAR_FORM = 'EDITOR_CONTACT_FORM_CLEAR_FORM'; | |||
| export const EDITOR_CONTACT_FORM_LOAD_FORM = 'EDITOR_CONTACT_FORM_LOAD_FORM'; | |||
| export const EDITOR_CONTACT_FORM_REMOVE_FIELD = 'EDITOR_CONTACT_FORM_REMOVE_FIELD'; | |||
| export const EDITOR_POST_CURRENT_ID = 'EDITOR_POST_CURRENT_ID'; | |||
There was a problem hiding this comment.
Should probably have some sort of verb in this action type name. Consider suffixing with _SET
artpi
force-pushed
the
update/redux-editor-actions-id
branch
from
8792410 to
4fd5b04
Compare
artpi
force-pushed
the
update/redux-editor-actions-id
branch
from
4fd5b04 to
3cf1fe9
Compare
|
We will hold off this PR for now. |
scruffian
removed
[Status] In Progress
[Status] Needs Review
What does it solve?
In PR #3202 I introduced atomic action creators to interact with currently edited post.
In PR #3183 @aduth has introduced
editPostmethod which requires postId and siteId.This PR provides post and siteId to the setTitle action creator as an example
[clickbait] Once you review, check this out:
Hans Rosling, Swedish statistitian proved that the most important achievement of the industrial revolution is a Washing Machine! I highly recommend his energetic and fascinating TED talk: https://www.ted.com/talks/hans_rosling_and_the_magic_washing_machine.
This is in progress, but I want to decide on the approach before I go through all of these actions.
CC @gwwar @aduth @rralian