Plans 2023: Implement storage add on dropdown

[jeyip]

Related to https://github.com/Automattic/martech/issues/1907

Proposed Changes

• User should be able to select additional storage for Business and Ecommerce plans:

  • Hide dropdown behind feature flag because we're waiting for storage caps to actually be lowered
  • Render storage selection dropdown
  • Ensure that dropdown is only displayed for Business / Ecommerce yearly plans

• What will be implemented in follow-up PRs:

  • Dropdown Functionality ( Plans 2023: Add functionality to storage add-on dropdown #79104 )
    • Addon is added to the plans checkout cart automatically
    • Plans prices in the UI update accordingly
    • Storage values in the plans comparison grid update accordingly
  • Add tracking event when user interacts with storage selection dropdown

GIF

Onboarding

/plans

Testing Instructions

• Check out this branch
• yarn && yarn start
• Navigate to any onboarding flow ( Ex. calypso.localhost:3000/start ) and complete steps until at plans pricing page
• Verify that the dropdown renders and different storage options can be selected
• Verify that the dropdown renders only for business and ecommerce plans for yearly plans
• Navigate to the /plans page and repeat the same verifications above
• Verify that the feature flag is working by either:
  • Navigating to /start/plans/?flags=-plans/upgradeable-storage
  • commenting out "plans/upgradeable-storage" in config/development.json and restarting the dev environment

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-75956

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-75956&env=jetpack

[jeyip]

Notes:

Hoping to have a PR or two that satisfies all requirements outlined here for Plans 2023 onboarding pages sometime tomorrow 🤞

Need to work on:

• Fixing width of dropdown
• Figuring out how to integrate usage of PRODUCT_1GB_SPACE in the pricing plans grid ( this is a bit of a heavier lift so I'm spelunking through the codebase )

[matticbot]

This PR modifies the release build for editing-toolkit

To test your changes on WordPress.com, run install-plugin.sh editing-toolkit add/plans-2023-upgradeable-storage on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-mMA-p2

[matticbot]

This PR modifies the release build for happy-blocks

To test your changes on WordPress.com, run install-plugin.sh happy-blocks add/plans-2023-upgradeable-storage on your sandbox.

To deploy your changes after merging, see the documentation: PCYsg-r7r-p2

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~222 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +473 B  (+0.0%)     +131 B  (+0.0%)
entry-main                  +473 B  (+0.0%)     +127 B  (+0.0%)
entry-subscriptions         +126 B  (+0.0%)      +36 B  (+0.0%)
entry-login                 +126 B  (+0.0%)      +36 B  (+0.0%)
entry-domains-landing       +126 B  (+0.0%)      +36 B  (+0.0%)
entry-browsehappy           +126 B  (+0.1%)      +36 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~589 bytes added 📈 [gzipped])

name                               parsed_size           gzip_size
update-design-flow                      +835 B  (+0.1%)     +189 B  (+0.1%)
plugins                                 +835 B  (+0.0%)     +190 B  (+0.0%)
plans                                   +835 B  (+0.1%)     +203 B  (+0.1%)
link-in-bio-tld-flow                    +835 B  (+0.1%)     +190 B  (+0.1%)
site-setup-flow                         +295 B  (+0.0%)      +61 B  (+0.0%)
site-purchases                          +295 B  (+0.0%)      +61 B  (+0.0%)
settings-jetpack                        +295 B  (+0.1%)      +61 B  (+0.0%)
scan                                    +295 B  (+0.0%)      +61 B  (+0.0%)
purchases                               +295 B  (+0.0%)      +61 B  (+0.0%)
purchase-product                        +295 B  (+0.2%)      +61 B  (+0.1%)
marketing                               +295 B  (+0.0%)      +61 B  (+0.0%)
jetpack-search                          +295 B  (+0.1%)      +61 B  (+0.1%)
jetpack-connect                         +295 B  (+0.0%)      +61 B  (+0.0%)
jetpack-cloud-settings                  +295 B  (+0.1%)      +61 B  (+0.0%)
jetpack-cloud-pricing                   +295 B  (+0.0%)      +61 B  (+0.0%)
jetpack-cloud-plugin-management         +295 B  (+0.0%)      +61 B  (+0.0%)
jetpack-cloud-partner-portal            +295 B  (+0.0%)      +61 B  (+0.0%)
jetpack-cloud-features-comparison       +295 B  (+0.1%)      +61 B  (+0.0%)
jetpack-cloud-agency-dashboard          +295 B  (+0.0%)      +61 B  (+0.0%)
import-hosted-site-flow                 +295 B  (+0.0%)      +61 B  (+0.0%)
import-flow                             +295 B  (+0.0%)      +61 B  (+0.0%)
free-flow                               +295 B  (+0.0%)      +61 B  (+0.0%)
domains                                 +295 B  (+0.0%)      +61 B  (+0.0%)
checkout                                +295 B  (+0.0%)      +61 B  (+0.0%)
backup                                  +295 B  (+0.0%)      +61 B  (+0.0%)
activity                                +295 B  (+0.0%)      +61 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~10548 bytes added 📈 [gzipped])

name                                                            parsed_size            gzip_size
async-load-calypso-my-sites-plan-features-2023-grid                +54238 B  (+37.6%)   +17518 B  (+37.2%)
async-load-signup-steps-plans-theme-preselected                      +835 B   (+0.4%)     +188 B   (+0.3%)
async-load-signup-steps-plans                                        +835 B   (+0.4%)     +188 B   (+0.3%)
async-load-signup-steps-plans-atomic-store                           +295 B   (+0.2%)      +61 B   (+0.1%)
async-load-calypso-my-sites-stats-jetpack-upsell-section             +295 B   (+0.4%)      +61 B   (+0.4%)
async-load-calypso-my-sites-checkout-modal                           +295 B   (+0.0%)      +61 B   (+0.0%)
async-load-calypso-blocks-editor-checkout-modal                      +295 B   (+0.0%)      +61 B   (+0.0%)
async-load-signup-steps-woocommerce-install-step-business-info       +103 B   (+0.2%)      +23 B   (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[jeyip]

@chriskmnds Addressed the first wave of comments 😄

This PR could use another look.

I'll touch base with designers about the styling deviations with what was in the mocks and with the @wordpress/components dropdown we're going with when the PR is looking more finalized.

[chriskmnds]

Code-wise looks great. The dropdown will probably need some restyling, but obviously something to go through designer input. If we keep using the Core component, then maybe the restyled one can go straight into @automattic/components, and let that propagate in the app and gradually deprecate the local/unpackaged Calypso component. Not sure if we are just adding more complexity though by keeping both and not just migrating the existing Calypso one under @automattic/components 🤷‍♂️

I tested in start and plans as outlined. A few points I noticed:

1. Without feature flag, title/"Storage" missing in respective columns:

2. With feature flag, "Storage"/title over dropdown should probably be bold like the rest:

3. I don't see any change in price in the UI when selecting different storage, or additional product added to cart when going to checkout. Is this something to come after backend changes?

[jeyip]

Status Update of Follow-Ups:

Bugs

• /start/onboarding-pm and toggling to the 2-yearly plan, the storage label will disappear.
  • The fix is here Storage Add-Ons: Display the storage label for multi-year plans #80155
• when clicking a dropdown item on a mobile resolution, the whole expanded feature list will fold, causing a weird jump:
  • TBD

Outstanding Discussions

• How should we represent the concepts of storage features and storage add-ons?
  • Potential fix is here Storage Add Ons: Implement Plans 2023 Features Grid Functionality #80114

Follow-up Tasks

• remove the local selectedStorage state from PlanFeatures2023Grid and use the wpcom-plan-ui data store instead
  • The fix is here Storage Add Ons: Move UI state into wpcom-plans-ui data store #80158
• Move calypso components into a package
  • Automattic Components: Add select dropdown to package #79255 (comment)
  • Automattic Components: Add count to package #79257 (comment)
  • Automattic Components: Add form label to package #79256 (comment)

cc @southp for visibility

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8679268

Thank you @jeyip for including a screenshot in the description! This is really helpful for our translators.

[chriskmnds]

could this be set to optional and avoid all the isAddOn: false assertions above (that make up most cases)

[jeyip]

Yes! I'll make a note of this and take care of it in either an upcoming or separate PR

[a8ci18n]

Translation for this Pull Request has now been finished.