Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Add-Ons: Display the storage label for multi-year plans #80155

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

jeyip
Copy link
Contributor

@jeyip jeyip commented Aug 2, 2023

Related to #79041 (review)

Proposed Changes

This PR fixes a bug where the storage label wasn't being displayed for multi-year plans.

image

GIF

2023-08-02 13 08 26

Testing Instructions

  • In calypso live or a local dev environment, navigate to /start/onboarding-pm
  • Follow onboarding steps until at the plans page
  • Ensure that the selected time interval is 2 years
  • Verify that storage labels appear in the

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@jeyip jeyip added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. 2023 Pricing Page ⚡ Changes for pricing page optimisation 2023 labels Aug 2, 2023
@jeyip jeyip self-assigned this Aug 2, 2023
@jeyip jeyip requested a review from a team as a code owner August 2, 2023 20:10
@jeyip jeyip requested a review from chriskmnds August 2, 2023 20:10
@matticbot
Copy link
Contributor

matticbot commented Aug 2, 2023

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ddc22 ddc22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@jeyip jeyip merged commit eccefea into trunk Aug 2, 2023
@jeyip jeyip deleted the fix/plans-2023-storage-labels-for-multi-year-plans branch August 2, 2023 21:15
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2023 Pricing Page ⚡ Changes for pricing page optimisation 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants