Storage Add Ons: Move UI state into wpcom-plans-ui data store

[jeyip]

Follow-up to #79041 (comment)

Just want to reemphasize this a little. Our immediate next priority for the plans package is #78266, which is about breaking apart the grid components and exporting individually. This is my next issue on the queue.

So we need to keep our focus/priorities on the refactor we discussed previously on a few occassions (to remove the local selectedStorage state from PlanFeatures2023Grid and use the wpcom-plan-ui data store instead)

Proposed Changes

As part of the plans 2023 pricing page refactor, @chriskmnds is breaking apart the pricing grid components ( features grid & comparison grid ) and exporting them individually.

To prevent roadblocks to his work, we want to avoid sharing UI state locally between the features grid and the comparison grid. As a result, we're moving any storage add ons UI state away from local state management and into the wpcom-plan-ui data store.

GIF

Testing Instructions

• Spin up a local dev environment or use calypso live
• Navigate to /start/plans?flags=plans/upgradeable-storage
• Verify that selecting items in the storage add ons dropdown continues to behave as expected. To be clear, all we're checking is that dropdown selections persist. No other functionality is wired up at this point
• Do the same for /plans

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-77699

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-77699&env=jetpack

[jeyip]

Note:

Naming this slice of state felt odd because I wasn't sure how to interpret the existing convention. A sibling reducer is called showDomainUpsellDialog. In the end, I tried to make the name as specific as possible, but I'm totally open to changing this

[jeyip]

@chriskmnds would you mind taking a look at this?

[chriskmnds]

Thanks for working on this! Left some comments below, #80158 (comment) seems critical and merits investigation. Overall looks good to me though.

[chriskmnds]

Asking here, so we can resolve in a thread (so not exactly related to this piece of code).

Do we expect to retrieve the selected storage from a location outside of the plans grid package (plan-features-2023-grid)? e.g. from checkout maybe? If that's the case, then we will need to set the value to persist in the data store, and possibly call an action to reset it when rendering the grid components (features table or comparison grid) in a "fire once" hook.

[jeyip]

Do we expect to retrieve the selected storage from a location outside of the plans grid package (plan-features-2023-grid)? e.g. from checkout maybe?

Not for the time being. checkout already has their own state management in place for add ons

[sharpirate]

Testing

For http://calypso.localhost:3000/start and http://calypso.localhost:3000/start/SITE_SLUG:

✔️ The dropdown works as expected both with keyboard and mouse. The selection is persisted.
✔️ The payload of the corresponding Redux actions looks good:

• 50 GB:

type:"WPCOM_PLANS_UI_SET_STORAGE_ADD_ON_FOR_PLAN"
addOnSlug:"50gb-storage"
plan:"business-bundle"

• 100 GB:

type:"WPCOM_PLANS_UI_SET_STORAGE_ADD_ON_FOR_PLAN"
addOnSlug:"50gb-storage-add-on"
plan:"business-bundle"

• 150 GB:

type:"WPCOM_PLANS_UI_SET_STORAGE_ADD_ON_FOR_PLAN"
addOnSlug:"100gb-storage-add-on"
plan:"business-bundle"

[sharpirate]

Do the same for /plans

I wasn't able to test /plans because when I go to http://calypso.localhost:3000/plans I get redirected to https://wordpress.com/pricing/, not sure if I'm missing something

NVM, I realized I was supposed to go to http://calypso.localhost:3000/plans/SITE_SLUG instead of http://calypso.localhost:3000/plans

[jeyip]

Thanks for all the feedback y'all! Taking a look now 👍

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~2040 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
plugins                   +5073 B  (+0.3%)    +1829 B  (+0.3%)
update-design-flow         +912 B  (+0.1%)     +100 B  (+0.0%)
link-in-bio-tld-flow       +912 B  (+0.1%)     +100 B  (+0.0%)
write-flow                 +656 B  (+0.1%)      +15 B  (+0.0%)
videopress-flow            +656 B  (+0.1%)      +15 B  (+0.0%)
signup                     +656 B  (+0.2%)      +15 B  (+0.0%)
jetpack-connect            +656 B  (+0.1%)      +15 B  (+0.0%)
home                       +656 B  (+0.0%)      +15 B  (+0.0%)
free-flow                  +656 B  (+0.1%)      +15 B  (+0.0%)
build-flow                 +656 B  (+0.1%)      +15 B  (+0.0%)
accept-invite              +656 B  (+0.2%)      +15 B  (+0.0%)
plans                      +256 B  (+0.0%)      +85 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~2169 bytes added 📈 [gzipped])

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected      +5166 B  (+1.3%)    +2169 B  (+1.8%)
async-load-signup-steps-plans                        +5166 B  (+1.3%)    +2169 B  (+1.8%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[sharpirate]

Code looks good and the PR tests well after the recent changes. 👍

[jeyip]

To avoid any more merge conflicts with this PR I'll be merging it shortly.

All comments have been addressed, but @chriskmnds if there's any more you'd like to add when you're back from AFK, I'll be happy to draft immediate follow-ups for any new concerns that pop up.