-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auth footer copy for Jetpack AI and Jetpack Boost A/B test #81871
Update auth footer copy for Jetpack AI and Jetpack Boost A/B test #81871
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~142 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested well! 🚢
Just left a minor suggestion. Thank you!
client/jetpack-connect/features.tsx
Outdated
const translate = useTranslate(); | ||
|
||
const col1Features = [ | ||
col1Features = col1Features || [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We created this component, and are the only ones using it. I think we can remove these default features and make the props required. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good to know :) I'll make the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in a15d9d3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works nice! Thanks @moon0326 🚀
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8991251 Thank you @moon0326 for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Related to woocommerce/woocommerce#39629
Proposed Changes
Testing Instructions
plugin_name=jetpack-ai
query param and refresh the pageplugin_name=jetpack-boost
and refresh the pageScreenshot 1
Screenshot 2
Pre-merge Checklist