Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auth footer copy for Jetpack AI and Jetpack Boost A/B test #81871

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

moon0326
Copy link
Contributor

Related to woocommerce/woocommerce#39629

Proposed Changes

  • Updated Auth Form Footer copies for Jetpack AI and Jetpack Boost A/B test

Testing Instructions

  1. Create a new JN site with WooCommerce
  2. Start the core profiler and proceed to the plugins page.
  3. Make sure to choose Jetpack
  4. Click the continue button to install
  5. You should be redirected to Jetpack connect page.
  6. Copy the URL
  7. Checkout this branch and open your local wp-calypso
  8. Replace the copied URL and replace the host to your local wp-calypso
  9. You should see Jetpack connect page
  10. Append plugin_name=jetpack-ai query param and refresh the page
  11. The feature list should contain lists from screenshot Default to Open #1
  12. Change the param to plugin_name=jetpack-boost and refresh the page
  13. The feature list should contain lists from screenshot Site Picker: All Sites: Improve Icon Composite #2

Screenshot 1
Screen Shot 2023-09-18 at 7 06 00 PM

Screenshot 2
Screen Shot 2023-09-18 at 7 05 54 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@moon0326 moon0326 requested review from a team, chihsuan and adrianduffell September 19, 2023 02:06
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

@matticbot
Copy link
Contributor

matticbot commented Sep 19, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~142 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +246 B  (+0.0%)     +142 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@chihsuan chihsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well! 🚢

Just left a minor suggestion. Thank you!

const translate = useTranslate();

const col1Features = [
col1Features = col1Features || [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We created this component, and are the only ones using it. I think we can remove these default features and make the props required. 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good to know :) I'll make the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in a15d9d3

Copy link
Contributor

@adrianduffell adrianduffell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works nice! Thanks @moon0326 🚀

@moon0326 moon0326 merged commit c0440cf into trunk Sep 19, 2023
3 checks passed
@moon0326 moon0326 deleted the update/39629-jetpack-ab-test-footer-copy-changes branch September 19, 2023 20:33
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 19, 2023
@a8ci18n
Copy link

a8ci18n commented Sep 19, 2023

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/8991251

Thank you @moon0326 for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Oct 2, 2023

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants