Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: Fix error from undefined longerPlanTermDefaultExperiment in Stepper use of plans step #96736

Merged

Conversation

chriskmnds
Copy link
Contributor

Related to #96174

Proposed Changes

Follow-up to #96174

We ignored usage in Stepper of the plans step from Start (/setup/onboarding/plans) and TS couldn't help flag this out (we never bothered to TS-ify plans step in Start). longerPlanTermDefaultExperiment.term would lead to uncaught type error.

Why are these changes being made?

Fix error.

Testing Instructions

  • Go to /setup/onboarding/plans. Ensure it renders the plans grid.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@chriskmnds chriskmnds self-assigned this Nov 25, 2024
@chriskmnds chriskmnds requested a review from jeyip November 25, 2024 16:04
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@chriskmnds chriskmnds added Multi-year Plans by Default Experiment and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@chriskmnds chriskmnds merged commit 9438d2d into trunk Nov 25, 2024
14 of 15 checks passed
@chriskmnds chriskmnds deleted the update/plans-grid-longer-term-default-fix-potential-error branch November 25, 2024 16:12
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 25, 2024
@chriskmnds chriskmnds changed the title Plans: Fix potential error from undefined longerPlanTermDefaultExperiment in Stepper use of plans step Plans: Fix error from undefined longerPlanTermDefaultExperiment in Stepper use of plans step Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants