Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Update Gutenberg contact from test to use contact form block #1640

Closed
JavonDavis opened this issue Nov 20, 2018 · 6 comments
Closed

Update Gutenberg contact from test to use contact form block #1640

JavonDavis opened this issue Nov 20, 2018 · 6 comments

Comments

@JavonDavis
Copy link
Contributor

Currently, the Gutenberg contact form test from #1639 uses a shortcode to insert the contact form block. Once the native contact form block is live we should use that or at the very least add to the existing test.

@simison
Copy link
Member

simison commented Nov 22, 2018

We now have the official Contact form block! 🎉

It's behind a feature flag on wpcom just like Gutenberg itself (gutenberg/block/jetpack-preset), but you can see it here:

https://wpcalypso.wordpress.com/gutenberg/post/

image

Here are Markdown block specs for inspiration:
https://github.com/Automattic/wp-e2e-tests/blob/fbf6b5d8fb37bbe3f3349b077383870a8d905300/specs-blocks/gutenberg-markdown-block-spec.js

@JavonDavis JavonDavis self-assigned this Nov 22, 2018
@JavonDavis
Copy link
Contributor Author

Nice! Thanks @simison!

@gwwar any idea when this will be available from Gutenberg in WPCOM?

I did test this out on a site with Gutenberg and Jetpack enabled and the form wasn't showing in the preview and publish.. I've attached screenshots and a recording link below. Ignoring the last part of the recording where it navigates back to the wp-admin vs wpcalypso environment was there more information I needed to enter to see it in the Preview and Publish?

screen shot 2018-11-22 at 11 08 44 am

screen shot 2018-11-22 at 11 09 24 am

screen shot 2018-11-22 at 11 09 42 am

screen shot 2018-11-22 at 11 10 11 am

Recording link: https://www.dropbox.com/s/6rtk1ipfmy5mr0x/contact-form.mov?dl=0

@gwwar
Copy link
Contributor

gwwar commented Nov 22, 2018

@lezama or @johnHackworth would be able to better answer that for block timelines.

@gwwar
Copy link
Contributor

gwwar commented Nov 22, 2018

Maybe soonish from pMz3w-9fO-p2

@lezama
Copy link

lezama commented Nov 22, 2018

We are aiming for early next week 👍

@JavonDavis
Copy link
Contributor Author

Closed in #1695

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants