Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Inline / TextElement inherit from InputElement to enable pointer/keyboard input handling #10186

Open
wieslawsoltes opened this issue Feb 3, 2023 · 4 comments

Comments

@wieslawsoltes
Copy link
Collaborator

wieslawsoltes commented Feb 3, 2023

Is your feature request related to a problem? Please describe.

In order to implement Hyperlink inline pointer / keyboard input is required.

Describe the solution you'd like

Make Inline / TextElement inherit from InputElement to enable pointer/keyboard input handling

Describe alternatives you've considered

Embedding TextBlock's controls?

Additional context

public abstract class Inline : TextElement

public abstract class TextElement : StyledElement

public class InputElement : Interactive, IInputElement

@Gillibald
Copy link
Contributor

The concrete implementation InputElement should not be required to handle input in some inline. Inline itself is not a Visual so this will not be possible. Instead only IInputElement should be required.

@Gillibald
Copy link
Contributor

So how did you end up implementing this on your side?

@wieslawsoltes
Copy link
Collaborator Author

wieslawsoltes commented Apr 13, 2023

@Gillibald Gillibald reopened this Apr 13, 2023
@Gillibald
Copy link
Contributor

I don't think this issue is solved. You are adding a styled button to the text layout. This issue is about making TextRun's hit testable for commands etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants