FindNameScope is being called once per named component assignment

[Rekkonnect]

Describe the bug

Avalonia.Generators.NameGenerator.AvaloniaNameSourceGenerator generates InitializeComponent and invokes FindNameScope as many times as there are named components within the control.

To Reproduce

1. Create any control (user or templated)
2. Add some components to the control like panels, text blocks, etc.
3. Set the Name attribute to name some of the contained controls
4. Go to the definition of InitializeComponent for the control
5. Observe the generated source

Example of generated code:

    partial class ContentEditor
    {
        internal global::Avalonia.Controls.Panel backgroundPanel;
        internal global::Avalonia.Controls.Panel linePanel;
        internal global::Avalonia.Controls.Panel scrollBarPanel;
        internal global::Avalonia.Controls.StackPanel contentStackPanel;

        /// <summary>
        /// Wires up the controls and optionally loads XAML markup and attaches dev tools (if Avalonia.Diagnostics package is referenced).
        /// </summary>
        /// <param name="loadXaml">Should the XAML be loaded into the component.</param>

        public void InitializeComponent(bool loadXaml = true)
        {
            if (loadXaml)
            {
                AvaloniaXamlLoader.Load(this);
            }

            backgroundPanel = this.FindNameScope()?.Find<global::Avalonia.Controls.Panel>("backgroundPanel");
            linePanel = this.FindNameScope()?.Find<global::Avalonia.Controls.Panel>("linePanel");
            scrollBarPanel = this.FindNameScope()?.Find<global::Avalonia.Controls.Panel>("scrollBarPanel");
            contentStackPanel= this.FindNameScope()?.Find<global::Avalonia.Controls.StackPanel>("contentStackPanel");
        }
    }

Expected behavior

The FindNameScope method's result can be stored in a variable before each component assignment. If there are no named components, the method should not be invoked at all, and no variable will have to be used for storing its result.

Avalonia version

11.0.10

OS

No response

Additional context

The FindNameScope method, to my understanding, will always return the same result within InitializeComponent when invoked on this. This results in redundant invocations of the method, which costs performance upon initializing an instance of the control.

[timunie]

Not sure it's a bug. But still a good idea. Would be worth a PR with a benchmark to test performance gain, if you are interested in.

[Rekkonnect]

I used the bug report template by mistake. I'll consider a PR for this