Use CompiledBindings for Fluent theme #7388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
approved these changes
Jan 19, 2022
danwalmsley
pushed a commit
that referenced
this pull request
Jan 24, 2022
Use CompiledBindings for Fluent theme # Conflicts: # src/Avalonia.Themes.Fluent/Controls/ManagedFileChooser.xaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR enables CompiledBindings in the Fluent Theme where it is possible.
Places where it isn't possible to use CompiledBindings:
Note:
I cant migrate almost everything in ManagedFileChooser because almost everything is located in internal classes and they cant be used for x:DataType.
Fixed issues
Should improve #5711