New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor nit: always put an adjective before `nonce`, because there are several kinds of `nonce`, and it's confusing. #10789

Open

iAmMichaelConnor opened this issue Dec 17, 2024 · 0 comments

Contributor

iAmMichaelConnor commented Dec 17, 2024

We have nonces for:

authwit
notes
enabling cancellation of user txs
poseidon2 encryption
the governance contract
and in some cases I haven't figured out what the nonce is for.

Let's put adjectives in front of them all, please :)

E.g. authwit_nonce, note_nonce, tx_nonce,...

iAmMichaelConnor mentioned this issue

refactor: fpc optimization, cleanup + docs #10555

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment