Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually have pxe.getNodeInfo().nodeVersion return a correct value. #10904

Open
FilipHarald opened this issue Dec 20, 2024 · 1 comment
Open
Assignees

Comments

@FilipHarald
Copy link
Contributor

This is not something that has worked in previous versions. I've just assumed that the nodeVersion is versioning a different thing. But seeing the comment here I realized that it actually should be the version for aztec-packages is, 0.67.1 at time of writing.

/** Version as tracked in the aztec-packages repository. */

I can't really find where it is being hard coded, but the current return-value is 0.1.0. Building a block explorer and network dashboard it would help greatly to know what version the node I'm talking to is running on.

@Maddiaa0
Copy link
Member

thanks for flagging this, it does appear that we manually update the package.json in our release workflow after the docker images are built, so this value reports wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants