Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Noir Contracts] Provide a way for a user to validate the hard-coded function selectors of a contract interface #1551

Closed
Tracked by #2792
iAmMichaelConnor opened this issue Aug 14, 2023 · 3 comments
Labels
C-aztec.nr Component: Aztec smart contract framework danger S-needs-discussion Status: Still needs more discussion before work can start.

Comments

@iAmMichaelConnor
Copy link
Contributor

If we continue with our current approach for generating contract interfaces, a developer shouldn't blindly trust these opaque hex function selectors. We probably need a way for a user (dev) who uses one of these contract interfaces to validate the correctness of the hex function selector.

Maybe we could include the selector in the generated ABIs? Or add a CLI command that outputs the list of functions and their selectors given a contract?

Issue began here: #1487 (comment)

@Maddiaa0
Copy link
Member

sounds like scope for another macro 😀 :

@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 25, 2023
This was referenced Oct 11, 2023
@Maddiaa0
Copy link
Member

@iAmMichaelConnor is this sufficiently fixed by #2686

@iAmMichaelConnor
Copy link
Contributor Author

I think it does, yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework danger S-needs-discussion Status: Still needs more discussion before work can start.
Projects
Archived in project
Development

No branches or pull requests

2 participants