Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SafeU120 lib for all operations in example contracts #1795

Closed
2 tasks done
Tracked by #2792
iAmMichaelConnor opened this issue Aug 24, 2023 · 3 comments
Closed
2 tasks done
Tracked by #2792

Use SafeU120 lib for all operations in example contracts #1795

iAmMichaelConnor opened this issue Aug 24, 2023 · 3 comments
Labels
A-security Area: Relates to security. Something is insecure.

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Aug 24, 2023 •
edited by LHerskind
Loading

Currently, the example contracts (notably the token contract examples) don't have checks for over/underflow when operating on values. We should use the SafeU120 library.

Dependencies
Beta Give feedback
  1. Move Lasse's SafeU120 file into a noir-libs/ so that other apps can use it. #1794
    refactor testing
    LHerskind
  2. SafeMath testing #1965
    devex fix testing
    LHerskind
@iAmMichaelConnor iAmMichaelConnor added the A-security Area: Relates to security. Something is insecure. label Aug 24, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 24, 2023
@iAmMichaelConnor iAmMichaelConnor mentioned this issue Aug 24, 2023
Merged
4 tasks
@iAmMichaelConnor iAmMichaelConnor added the S-blocked Status: Blocked label Aug 24, 2023
@LHerskind
Copy link
Contributor

Most of these also have insecure logic so seems like a hello kitty bandage on a torso without a head. Think it would make sense to do as part of a large redo of those tokens as part of #1743.

@iAmMichaelConnor iAmMichaelConnor added the C-aztec.nr Component: Aztec smart contract framework label Aug 25, 2023
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 25, 2023
@LHerskind LHerskind mentioned this issue Oct 11, 2023
Open
@LHerskind LHerskind removed the S-blocked Status: Blocked label Oct 11, 2023
@LHerskind
Copy link
Contributor

Not blocked by lacking implementation anymore. But some of the prior statement still holds.

@LHerskind LHerskind mentioned this issue Oct 11, 2023
Closed
@LHerskind LHerskind removed the C-aztec.nr Component: Aztec smart contract framework label Oct 11, 2023
@iAmMichaelConnor
Copy link
Contributor Author

Closing, as it seems completed

@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-security Area: Relates to security. Something is insecure.
Projects
A3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LHerskind @iAmMichaelConnor