Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make noir-libs a separate package (name tbd) #1878

Closed
iAmMichaelConnor opened this issue Aug 30, 2023 · 5 comments
Closed

Make noir-libs a separate package (name tbd) #1878

iAmMichaelConnor opened this issue Aug 30, 2023 · 5 comments
Labels
C-aztec.nr Component: Aztec smart contract framework T-refactor Type: this code needs refactoring

Comments

@iAmMichaelConnor
Copy link
Contributor

noir-libs should be downloadable as its own thing, without downloading the entire monorepo.

I wouldn't go as far as to put the code in a separate repo though. Monorepo removes friction from developing.
Thoughts @LHerskind @ludamad @Maddiaa0 @sirasistant ?

(#1759 (comment))

@iAmMichaelConnor iAmMichaelConnor added T-refactor Type: this code needs refactoring C-aztec.nr Component: Aztec smart contract framework labels Aug 30, 2023
@sirasistant
Copy link
Contributor

sirasistant commented Aug 30, 2023

Do you mean in nargo? You can just add it as a dependency on Nargo.toml using

easy_private_state = { git="https://github.com/AztecProtocol/aztec-packages", tag="master", directory="yarn-project/noir-libs/easy-private-state" }

after #1335 was done.
Why would you need to download it manually?

@sirasistant
Copy link
Contributor

Maybe we can also release it in zip downloadable form, just in case 🤔

@Maddiaa0
Copy link
Member

Maddiaa0 commented Aug 30, 2023

I think not having to include the directory bit would be useful. Maybe (AnOTheR) git subrepo. Although this is a great solution I wasnt aware existed

@iAmMichaelConnor
Copy link
Contributor Author

I suspect the mirror repo for aztec.nr achieves this, and this can be closed?

@LHerskind
Copy link
Contributor

Yep. Should be fine to close here. The naming might be good to think about though with so many different things living in there 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-aztec.nr Component: Aztec smart contract framework T-refactor Type: this code needs refactoring
Projects
Archived in project
Development

No branches or pull requests

4 participants