refactor(circuits): - use msgpack for cbind routines of native private kernel circuits #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
changed the title
jeanmon
commented
Sep 1, 2023
kevaundray
changed the title
jeanmon
force-pushed
the
jm/738-circuit-cbind-msgpack
branch
8 times, most recently
from
73f8620
to
10ef69f
Compare
jeanmon
force-pushed
the
jm/738-circuit-cbind-msgpack
branch
from
10ef69f
to
c4fb3cd
Compare
|
Tagging @ludamad if you would like to have a look. |
jeanmon
force-pushed
the
jm/738-circuit-cbind-msgpack
branch
4 times, most recently
from
8387285
to
1a6f535
Compare
ludamad
reviewed
Sep 5, 2023
yarn-project/circuits.js/src/structs/kernel/__snapshots__/index.test.ts.snap
Outdated
Show resolved
Hide resolved
|
Good with just commenting the tests for now, probably wise. Just not sure about the updated spec files, is there are a reason for them to have changed? |
ludamad
reviewed
Sep 5, 2023
ludamad
reviewed
Sep 5, 2023
@ludamad I did not change much in .test.cpp. The diff appears larger than it is due to the commenting of the test. The other commented test was newly added. |
jeanmon
force-pushed
the
jm/738-circuit-cbind-msgpack
branch
from
1a6f535
to
43b6a1f
Compare
suyash67
reviewed
Sep 6, 2023
suyash67
reviewed
Sep 6, 2023
circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_ordering.test.cpp
Show resolved
Hide resolved
suyash67
approved these changes
Sep 6, 2023
spypsy
pushed a commit
that referenced
this pull request
Sep 6, 2023
🤖 I have created a new Aztec Packages release --- ## [0.1.0-alpha60](v0.1.0-alpha59...v0.1.0-alpha60) (2023-09-06) ### Features * Goblin recursive verifier ([#1822](#1822)) ([f962cb6](f962cb6)) * initial `is_valid` eip1271 style wallet + minimal test changes ([#1935](#1935)) ([f264c54](f264c54)) ### Bug Fixes * benchmark git repo ([#2041](#2041)) ([3c696bb](3c696bb)) * cli canary & deployment ([#2053](#2053)) ([1ddd24a](1ddd24a)) * **rpc:** Fixes getNodeInfo serialisation ([#1991](#1991)) ([0a29fa8](0a29fa8)) ### Miscellaneous * **circuits:** - use msgpack for cbind routines of native private kernel circuits ([#1938](#1938)) ([3dc5c07](3dc5c07)) * **docs:** API docs stucture ([#2014](#2014)) ([9aab9dd](9aab9dd)) * Update function selector computation ([#2001](#2001)) ([e07ea1a](e07ea1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2011
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.