Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't tag manifest as latest when deploying to dockerhub #2315

Open
iAmMichaelConnor opened this issue Sep 15, 2023 · 0 comments
Open

Don't tag manifest as latest when deploying to dockerhub #2315

iAmMichaelConnor opened this issue Sep 15, 2023 · 0 comments
Labels
A-devops Area: Devops. E.g. CI / build systems

Comments

@iAmMichaelConnor
Copy link
Contributor

iAmMichaelConnor commented Sep 15, 2023 •
edited
Loading

LGTM! One comment though: it seems we're always tagging the multi-arch manifest we deploy to dockerhub as latest. This can backfire if we ever want to release a fix for an old version (eg we got 1.0 and 2.0 out there, and we want to release a 1.1 with a fix, then 1.1 would overtake 2.0 as latest). But I'm not sure if we already had this problem before in our deployment scripts.

Originally posted by @spalladino in #2305 (review)
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 15, 2023
@iAmMichaelConnor iAmMichaelConnor added the T-fix Type: fix this. Not quite a bug. label Sep 15, 2023
@iAmMichaelConnor iAmMichaelConnor added A-devops Area: Devops. E.g. CI / build systems and removed T-fix Type: fix this. Not quite a bug. labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-devops Area: Devops. E.g. CI / build systems
Projects
A3
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iAmMichaelConnor