You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The macros are currently not handling the shared state sizing correctly when assigning storage slots.
For the SharedImmutable it should be fairly straightforward. When #4738 is implemented, it should be handles similar to public state.
However, when implementing the shared mutable storage (#4761) the type of storage will be storing N*2 + 1 value to state, and not just the N that the type T would normally have.
This is to account for the before and after.
This means that the computation needs to be altered slightly, to ensure that we don't end up overwriting the storage by mistake.
The text was updated successfully, but these errors were encountered:
LHerskind
changed the title
feat(AztecMacro): Correct serialized size computation for shared and immutable state
feat(AztecMacro): Correct serialized size computation for shared mutable state
Mar 8, 2024
LHerskind
changed the title
feat(AztecMacro): Correct serialized size computation for shared mutable state
feat(AztecMacro): Correct serialized size computation for shared state
Mar 11, 2024
The macros are currently not handling the shared state sizing correctly when assigning storage slots.
For the
SharedImmutable
it should be fairly straightforward. When #4738 is implemented, it should be handles similar to public state.However, when implementing the shared mutable storage (#4761) the type of storage will be storing
N*2 + 1
value to state, and not just theN
that the typeT
would normally have.This is to account for the
before
andafter
.This means that the computation needs to be altered slightly, to ensure that we don't end up overwriting the storage by mistake.
The text was updated successfully, but these errors were encountered: