Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Verify registered artifact matches instance class id #5297

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

spalladino
Copy link
Collaborator

When registering a new contract instance with an artifact, validate that the computed artifact class id matches the class id from the instance preimage.

@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • note_history_successful_decrypting_time_in_ms (10): 4,138 (+69%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6e218d41 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 66,388 239,116 469,064
l1_rollup_execution_gas 647,486 929,474 1,305,244
l2_block_processing_time_in_ms 1,271 (-2%) 4,883 (-3%) 9,363 (+3%)
note_successful_decrypting_time_in_ms 180 (-8%) 506 (-10%) 965 (-6%)
note_trial_decrypting_time_in_ms 84.4 (-19%) 131 (+73%) 98.6 (+74%)
l2_block_building_time_in_ms 18,108 (-2%) 68,587 (-1%) 136,232 (-1%)
l2_block_rollup_simulation_time_in_ms 8,085 (-2%) 28,652 56,797 (-1%)
l2_block_public_tx_process_time_in_ms 10,000 (-1%) 39,880 (-1%) 79,337 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,715 (-3%) 29,380 (+9%)
note_history_successful_decrypting_time_in_ms 1,254 (+2%) ⚠️ 4,138 (+69%)
note_history_trial_decrypting_time_in_ms 93.3 (+39%) 170 (-2%)
node_database_size_in_bytes 19,107,920 35,713,104
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 285 (+1%) 44,366 28,244
private-kernel-ordering 217 52,868 14,326
base-parity 1,901 (+3%) 128 311
base-rollup 728 (+1%) 165,787 925
root-parity 1,482 (-9%) 1,244 311
root-rollup 63.6 (+1%) 4,487 789
private-kernel-inner 647 (-1%) 73,771 28,244
public-kernel-app-logic 469 (+4%) 35,260 28,215
public-kernel-tail 183 (+5%) 40,926 28,215
merge-rollup 8.37 (-1%) 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.7 (+6%) 16.1 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.627 (+7%) 0.499 (+1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.6 (+1%) 72.1 (-1%) 230 (-1%) 443 (-1%) 872 1,724 N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.478 (+1%) 0.445 0.420 0.416 0.415 0.413 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 55.8 (+2%) 106 (-1%) 334 (-2%) 658 1,309 (-2%) 2,613 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.498 (+2%) 0.481 0.456 (-1%) 0.454 0.452 (-1%) 0.454 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 64.1 (+4%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.561 (+5%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,012

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,258 (-2%) 1,758
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 11.4 (+1%) 1,307 (+4%)

@spalladino spalladino merged commit dd56a0e into master Mar 18, 2024
95 checks passed
@spalladino spalladino deleted the palla/check-artifact branch March 18, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants