Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(AztecNr): Clean up TransparentNote #5656

Closed
Tracked by #2783
benesjan opened this issue Apr 10, 2024 · 0 comments · Fixed by #5904
Closed
Tracked by #2783

refactor(AztecNr): Clean up TransparentNote #5656

benesjan opened this issue Apr 10, 2024 · 0 comments · Fixed by #5904

Comments

@benesjan
Copy link
Contributor

benesjan commented Apr 10, 2024

Remove unused functions and secret from TransparentNote as it's unused.

Note that there is an issue with potential nullifier collisions in case the same secretHash would be used 2 times. This can be tackled by implementing nonces as is described in this issue. Note that this will make it more tricky to add a note because we will need to somehow set the nonce when passing the note to pxe.addNote.

Either link the issue in the transparent note code or figure out a way how to handle it via some other mechanism.

@LHerskind LHerskind changed the title Clean up TransparentNote and remove duplicates refactor(AztecNr): Clean up TransparentNote and remove duplicates Apr 15, 2024
@benesjan benesjan changed the title refactor(AztecNr): Clean up TransparentNote and remove duplicates refactor(AztecNr): Clean up TransparentNote Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant