Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable bench-summary in CI #6183

Closed
TomAFrench opened this issue May 3, 2024 · 0 comments · Fixed by #6211
Closed

Re-enable bench-summary in CI #6183

TomAFrench opened this issue May 3, 2024 · 0 comments · Fixed by #6211
Assignees

Comments

@TomAFrench
Copy link
Member

Benchmark summaries were disabled in 67485f1 so we no longer get benchmarks commented on PRs.

This was done as we were getting this error after Charlie's migration of docker images.
Screenshot 2024-05-02 at 7 07 50 PM

Context from Palla.

RE awscli it's possible you can just remove the apt install awscli from the Earthfiles, since they should all be using Charlie's base image which apparently includes it (see here). You should also ensure the base image on all the scripts that were installing awscli is switched to Charlie's, or install the awscli via curl.

@github-project-automation github-project-automation bot moved this to Todo in A3 May 3, 2024
@TomAFrench TomAFrench self-assigned this May 3, 2024
@TomAFrench TomAFrench added this to Noir May 3, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir May 3, 2024
@TomAFrench TomAFrench linked a pull request May 3, 2024 that will close this issue
@TomAFrench TomAFrench moved this from 📋 Backlog to 🚧 Blocked in Noir May 10, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 May 14, 2024
@github-project-automation github-project-automation bot moved this from 🚧 Blocked to ✅ Done in Noir May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant