-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prototype for using the databus with ACIR opcode #6366
Conversation
Benchmark resultsNo base data found for comparison. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | Transaction processing duration by data writes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I just left one comment around how block constraints are set. It seems to me that there's room for improvement there but this might not be the time/place. If you feel like adding some comments there though that would be helpful
Related to noir-lang/noir#4974
The PR implements logic in BB to handle ACIR opcodes for the databus.
Because the databus in BB works only with Goblin which is not yet supported by Noir, the code is not fully tested, so this is only prototype code.
Using the databus with UltraPlonk will result in a failing ASSERT.
I have updated the BB unit test to work with GoblinPlonk, so the BB code is tested.