-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: representation of a grumpkin verifier commitment key inside a bn254 circuit #6593
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG, just pointed out one typo
auto recursive_vk = std::make_shared<VK>(&builder, num_points, native_vk); | ||
EXPECT_EQ(native_vk->get_first_g1(), recursive_vk->get_first_g1().get_value()); | ||
auto* native_monomial_points = native_vk->get_monomial_points(); | ||
auto recursive_monomial_ponts = recursive_vk->get_monomial_points(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
points*
Benchmark resultsNo base data found for comparison. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | Transaction processing duration by data writes.
|
…rotocol/aztec-packages into mm/stdlib-verifier-commitment-key
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
This PR creates a representation of Grumpkin
VerifierCommitmentKey
inside a bn254 circuit and ensure consistency with native part. This is necessary to enable IPA verification in the recursive setting. I took a minimalist approach and excluded thepippenger_runtime_state
as we will initially do MSMs in the IPA verifier viabatch_mul
. This is because pippenger needs to be rewritten to be usable in a recursive settings. I also restricted access to theVerifierSrs
via member functions in the nativeVerifierCommitmentKey
. This work is a step towards the ECCVM recursive verifier.