-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avm): avm keccak permutation #6596
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @IlyasRidhuan and the rest of your teammates on Graphite |
bef8263
to
c1806ec
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Benchmark resultsNo metrics with a significant change found. Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Proof generationEach column represents the number of threads used in proof generation.
L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.
Stats on running time collected for app circuits
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contract classes are registered in the tx.
Transaction size based on fee payment method | Metric | | |
1cc6b93
to
7ba1cc9
Compare
c1806ec
to
b79a9b7
Compare
7ba1cc9
to
5445448
Compare
b79a9b7
to
15f4013
Compare
5445448
to
1d469dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! See comments.
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
barretenberg/cpp/src/barretenberg/vm/tests/avm_execution.test.cpp
Outdated
Show resolved
Hide resolved
15f4013
to
bdabf50
Compare
0633e92
to
442b868
Compare
442b868
to
dafcfbf
Compare
Please read contributing guidelines and remove this line.