feat: VK tree #6914

sirasistant · 2024-06-05T16:12:28Z

Implements the VK tree in circuits, contract and TS

Adds VK generation to bootstrapping protocol circuits with multiple caching levels (disk, remote cache, bootstrap fast)
Adds VK tree root to the constants of the TX
Adds membership checks for VK tree in all circuits that verify previous circuits, including checks on the index by expressing ALLOWED_PREVIOUS_CIRCUITS
Adds VK tree root to public inputs of root rollup
Adds VK tree root in the rollup contract
Exports VKs and VK tree in noir-protocol-circuits-types
Refactors TS to use the the VKs in noir-protocol-circuits-types and removes mocked VKs
Updates TS to pass the VK tree root on contract deployment and private kernel init

github-actions · 2024-06-26T17:15:40Z

Changes to circuit sizes

Generated at commit: 1851a1723456492c45e4de3ac83ea71fe3017f48, compared to commit: 0414eb50fff3fbaf12a15bfc2e111b480bb750a4

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
parity_root	+43 ❌	+2.01%	+3,582 ❌	+0.32%
private_kernel_empty_simulated	0 ➖	0.00%	+1 ❌	+0.26%
private_kernel_tail_simulated	0 ➖	0.00%	+1 ❌	+0.26%
public_kernel_tail_simulated	0 ➖	0.00%	+1 ❌	+0.26%
rollup_root	+100 ❌	+4.61%	+1,545 ❌	+0.17%
private_kernel_reset_small	+40 ❌	+0.06%	+928 ❌	+0.11%
rollup_merge	+90 ❌	+6.72%	+648 ❌	+0.11%
private_kernel_reset_medium	+40 ❌	+0.06%	+928 ❌	+0.10%
private_kernel_inner	+41 ❌	+0.09%	+938 ❌	+0.09%
private_kernel_reset_big	+40 ❌	+0.04%	+928 ❌	+0.08%
private_kernel_tail	+41 ❌	+0.19%	+938 ❌	+0.08%
public_kernel_setup	+40 ❌	+0.02%	+929 ❌	+0.07%
public_kernel_teardown	+45 ❌	+0.02%	+936 ❌	+0.07%
public_kernel_app_logic	+45 ❌	+0.02%	+935 ❌	+0.07%
private_kernel_tail_to_public	+41 ❌	+0.01%	+938 ❌	+0.06%
private_kernel_reset	+40 ❌	+0.03%	+928 ❌	+0.05%
private_kernel_init_simulated	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_inner_simulated	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_reset_simulated	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_reset_simulated_big	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_reset_simulated_medium	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_reset_simulated_small	0 ➖	0.00%	+1 ❌	+0.04%
private_kernel_tail_to_public_simulated	0 ➖	0.00%	+1 ❌	+0.03%
public_kernel_app_logic_simulated	0 ➖	0.00%	+1 ❌	+0.03%
public_kernel_setup_simulated	0 ➖	0.00%	+1 ❌	+0.03%
public_kernel_teardown_simulated	0 ➖	0.00%	+1 ❌	+0.03%
rollup_base	+37 ❌	+0.01%	+924 ❌	+0.03%
public_kernel_tail	+40 ❌	+0.00%	+930 ❌	+0.02%
private_kernel_init	+2 ❌	+0.01%	+3 ❌	+0.00%
private_kernel_empty	+1 ❌	+0.11%	+2 ❌	+0.00%
parity_base	+1 ❌	+0.29%	0 ➖	0.00%
rollup_base_simulated	0 ➖	0.00%	-3 ✅	-8.33%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
parity_root	2,182 (+43)	+2.01%	1,132,877 (+3,582)	+0.32%
private_kernel_empty_simulated	1 (0)	0.00%	389 (+1)	+0.26%
private_kernel_tail_simulated	1 (0)	0.00%	389 (+1)	+0.26%
public_kernel_tail_simulated	1 (0)	0.00%	389 (+1)	+0.26%
rollup_root	2,268 (+100)	+4.61%	912,731 (+1,545)	+0.17%
private_kernel_reset_small	62,383 (+40)	+0.06%	829,874 (+928)	+0.11%
rollup_merge	1,429 (+90)	+6.72%	602,715 (+648)	+0.11%
private_kernel_reset_medium	72,378 (+40)	+0.06%	953,693 (+928)	+0.10%
private_kernel_inner	44,646 (+41)	+0.09%	1,046,928 (+938)	+0.09%
private_kernel_reset_big	92,367 (+40)	+0.04%	1,201,410 (+928)	+0.08%
private_kernel_tail	21,418 (+41)	+0.19%	1,247,381 (+938)	+0.08%
public_kernel_setup	182,750 (+40)	+0.02%	1,320,322 (+929)	+0.07%
public_kernel_teardown	241,282 (+45)	+0.02%	1,384,518 (+936)	+0.07%
public_kernel_app_logic	241,086 (+45)	+0.02%	1,384,279 (+935)	+0.07%
private_kernel_tail_to_public	444,636 (+41)	+0.01%	1,680,709 (+938)	+0.06%
private_kernel_reset	132,343 (+40)	+0.03%	1,696,842 (+928)	+0.05%
private_kernel_init_simulated	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_inner_simulated	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_reset_simulated	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,249 (+1)	+0.04%
private_kernel_tail_to_public_simulated	1 (0)	0.00%	3,264 (+1)	+0.03%
public_kernel_app_logic_simulated	1 (0)	0.00%	3,264 (+1)	+0.03%
public_kernel_setup_simulated	1 (0)	0.00%	3,264 (+1)	+0.03%
public_kernel_teardown_simulated	1 (0)	0.00%	3,264 (+1)	+0.03%
rollup_base	339,265 (+37)	+0.01%	3,065,074 (+924)	+0.03%
public_kernel_tail	971,097 (+40)	+0.00%	4,408,451 (+930)	+0.02%
private_kernel_init	25,833 (+2)	+0.01%	380,760 (+3)	+0.00%
private_kernel_empty	923 (+1)	+0.11%	271,656 (+2)	+0.00%
parity_base	347 (+1)	+0.29%	79,811 (0)	0.00%
rollup_base_simulated	1 (0)	0.00%	33 (-3)	-8.33%

AztecBot · 2024-06-27T16:15:12Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (root-parity): 69.3 (+42%)
protocol_circuit_simulation_time_in_ms (base-rollup): 4,126 (-31%)
protocol_circuit_simulation_time_in_ms (public-kernel-setup): 188 (-57%)
protocol_circuit_simulation_time_in_ms (public-kernel-app-logic): 145 (-63%)
protocol_circuit_simulation_time_in_ms (public-kernel-tail): 887 (-22%)
protocol_circuit_simulation_time_in_ms (public-kernel-teardown): 133 (-65%)
protocol_circuit_simulation_time_in_ms (merge-rollup): 39.9 (+37%)
protocol_circuit_input_size_in_bytes (base-parity): 160 (+25%)
protocol_circuit_output_size_in_bytes (base-parity): 96.0 (+50%)
protocol_circuit_output_size_in_bytes (root-parity): 96.0 (+50%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 65.9 (-55%)
avm_simulation_time_ms (Benchmarking:increment_balance): 1,310 (-34%)
avm_simulation_time_ms (Token:_increase_public_balance): 15.0 (-71%)
avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 160 (+39%)
protocol_circuit_witness_generation_time_in_ms (base-parity): 901 (-34%)
protocol_circuit_num_public_inputs (base-parity): 3.00 (+50%)
l2_block_building_time_in_ms (4): 12,872 (-32%)
l2_block_building_time_in_ms (8): 25,482 (-32%)
l2_block_building_time_in_ms (16): 49,616 (-33%)
l2_block_rollup_simulation_time_in_ms (4): 12,871 (-32%)
l2_block_rollup_simulation_time_in_ms (8): 25,482 (-32%)
l2_block_rollup_simulation_time_in_ms (16): 49,615 (-33%)
l2_block_public_tx_process_time_in_ms (4): 10,840 (-33%)
l2_block_public_tx_process_time_in_ms (8): 23,275 (-33%)
l2_block_public_tx_process_time_in_ms (16): 47,391 (-33%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,784 (+1%)	1,572 (+2%)	724 (+3%)	766 (+1%)	790 (+2%)
proof_construction_time_sha256_30_ms	12,235 (+4%)	3,231 (+3%)	1,444 (+3%)	1,456 (+1%)	1,485 (+2%)
proof_construction_time_sha256_100_ms	44,704 (+2%)	12,020 (+2%)	5,655 (+5%)	5,524 (+2%)	5,474 (+3%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0	88.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,531 (+1%)	419 (+1%)	201 (+1%)	227 (+3%)	268 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,824 (+1%)	1,609 (+3%)	738 (+2%)	808 (+3%)	805 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,472	9,476
l1_rollup_execution_gas	613,492	613,651	613,806
l2_block_processing_time_in_ms	758	1,423	2,712
l2_block_building_time_in_ms	⚠️ 12,872 (-32%)	⚠️ 25,482 (-32%)	⚠️ 49,616 (-33%)
l2_block_rollup_simulation_time_in_ms	⚠️ 12,871 (-32%)	⚠️ 25,482 (-32%)	⚠️ 49,615 (-33%)
l2_block_public_tx_process_time_in_ms	⚠️ 10,840 (-33%)	⚠️ 23,275 (-33%)	⚠️ 47,391 (-33%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,102 (-2%)	9,917
node_database_size_in_bytes	12,419,152	16,199,760
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	109 (-1%)	407 (+4%)	15,207 (+5%)	20,022	55,054	74,464	2,260	524,288
private-kernel-inner	221	703	30,058 (-2%)	82,186	55,054	74,464	2,260	1,048,576
private-kernel-tail	1,057 (-1%)	2,453 (-3%)	54,384 (-2%)	62,441	62,089	14,944	400	2,097,152
base-parity	6.26 (+2%)	⚠️ 901 (-34%)	2,622 (-1%)	⚠️ 160 (+25%)	⚠️ 96.0 (+50%)	2,240 (+1%)	⚠️ 3.00 (+50%)	131,072
root-parity	⚠️ 69.3 (+42%)	72.9 (+4%)	42,677 (+2%)	27,868 (+3%)	⚠️ 96.0 (+50%)	2,752 (+1%)	19.0 (+6%)	2,097,152
base-rollup	⚠️ 4,126 (-31%)	4,847 (-2%)	91,670 (+2%)	172,028 (+1%)	632 (-13%)	3,552 (-3%)	44.0 (-6%)	4,194,304
root-rollup	126 (+15%)	90.4 (+5%)	23,834 (+1%)	25,053 (-1%)	652 (+5%)	3,488 (+1%)	42.0 (+2%)	1,048,576
public-kernel-setup	⚠️ 188 (-57%)	2,385 (-1%)	42,729 (+2%)	103,915 (+2%)	80,310	106,944	3,275	2,097,152
public-kernel-app-logic	⚠️ 145 (-63%)	3,269	42,655 (+3%)	103,915 (+2%)	80,310	106,944	3,275	2,097,152
public-kernel-tail	⚠️ 887 (-22%)	25,077 (-8%)	177,463	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	292	1,307 (+5%)	28,024 (+5%)	79,305	55,054	74,464	2,260	1,048,576
public-kernel-teardown	⚠️ 133 (-65%)	3,274 (-2%)	42,061 (-3%)	103,915 (+2%)	80,310	106,944	3,275	2,097,152
merge-rollup	⚠️ 39.9 (+37%)	N/A	N/A	16,094 (-2%)	632 (-13%)	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	9,615 (+11%)	59,641 (-3%)	N/A	N/A	106,944	3,275	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,364	393	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,364	24.6	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,364	647	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,364	561 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,364	475	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,364	830	16,000	4,800	131,072	433
Token:privately_mint_private_note	1,280	9,364	538 (-2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,364	99.2 (-1%)	16,000	1,702	65,536	433
Token:transfer	1,312	9,364	1,618	16,000	11,399 (-3%)	524,288	433
AuthRegistry:set_authorized (avm)	19,226	N/A	N/A	91,264	1,272	N/A	N/A
FPC:prepare_fee (avm)	26,668	N/A	N/A	91,328	2,716 (-2%)	N/A	N/A
Token:transfer_public (avm)	42,918	N/A	N/A	91,328	3,763 (+1%)	N/A	N/A
AuthRegistry:consume (avm)	33,104	N/A	N/A	91,264	2,745 (+1%)	N/A	N/A
FPC:pay_refund (avm)	36,833	N/A	N/A	91,296	23,963 (+1%)	N/A	N/A
Benchmarking:create_note	1,344	9,364	467	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,364	41.4 (+1%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,364	1,333 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,364	1,709 (-1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	80.8 (+16%)	13,790
GasToken:set_portal	12.7 (-6%)	3,339
Token:constructor	100 (+7%)	23,692
FPC:constructor	72.3 (+16%)	13,592
GasToken:mint_public	59.5 (+18%)	10,158
Token:mint_public	55.0 (-15%)	19,034
Token:assert_minter_and_mint	⚠️ 65.9 (-55%)	12,925
AuthRegistry:set_authorized	32.8 (+18%)	7,812
FPC:prepare_fee	99.6 (-1%)	15,062
Token:transfer_public	34.5 (+26%)	31,218
FPC:pay_refund	131 (+1%)	25,260
Benchmarking:increment_balance	⚠️ 1,310 (-34%)	15,267
Token:_increase_public_balance	⚠️ 15.0 (-71%)	15,006
FPC:pay_refund_with_shielded_rebate	⚠️ 160 (+39%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.599	0.515	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.1 (-1%)	75.9	131	246	471
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.491 (-1%)	0.466	0.450	0.447	0.440
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.5	112 (-1%)	183	355 (-1%)	699
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.502	0.501 (-1%)	0.485	0.482 (-1%)	0.480
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.518	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,090	667,873

Transaction size based on fee payment method

| Metric | |
| - | |

…packages into arv/constrained_vks

yarn-project/end-to-end/package.json

…packages into arv/constrained_vks

LeilaWang

Brilliant 🎉

* master: (176 commits) refactor: counters (#7342) chore: notify Noir team on changes to the stdlib (#7387) chore(bb): do not instantiate Relation (#7389) chore(avm): avoid including flavor where possible (#7361) chore(avm): better log_derivative_inverse_round (#7360) chore(avm): smaller prover (#7359) chore(avm): smaller transcript (#7357) feat: Sync from noir (#7352) feat: VK tree (#6914) chore(docs): Update token tutorial (#7241) chore: sync external contributions (#6984) fix: privacy leak in private refund (#7358) fix: included argshash computation in public call_interfaces and cleanup (#7354) docs: making private refunds smooth-brain friendly (#7343) refactor: optimize public call stack item hashing (#7330) fix: Allow importing notes from other contracts and inject them in the macros (#7349) refactor: Optimize private call stack item hash for gate count (#7285) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](#6914)) ([8631237](8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](6137a10)) * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](6137a10)) * TXE docs and usability ([#7305](#7305)) ([6b2a351](6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](6137a10)) * VK tree ([#6914](#6914)) ([8631237](8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](#7349)) ([586c0b0](586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](#7354)) ([13e9b94](13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](6137a10)) * Privacy leak in private refund ([#7358](#7358)) ([e05f6f0](e05f6f0)), closes [#7321](#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) * **docs:** Fix link to docker ([#7395](#7395)) ([ad4a401](ad4a401)) * **docs:** Update token tutorial ([#7241](#7241)) ([0414eb5](0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](6137a10)) * Extracts refactoring of reading error payloads from [#5403](#5403) (noir-lang/noir#5413) ([6137a10](6137a10)) * Generate declaration files for VKs ([#7391](#7391)) ([7c96636](7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](6137a10)) * Notify Noir team on changes to the stdlib ([#7387](#7387)) ([061aac3](061aac3)) * Optimize private call stack item hash for gate count ([#7285](#7285)) ([783d9b6](783d9b6)) * Optimize public call stack item hashing ([#7330](#7330)) ([4a5093c](4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](9eb8d1c)) * Sync external contributions ([#6984](#6984)) ([a265b29](a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](#7343)) ([533c937](533c937)) * Update overview.md (fix link text) ([#7344](#7344)) ([79e5856](79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * TXE docs and usability ([#7305](AztecProtocol/aztec-packages#7305)) ([6b2a351](AztecProtocol/aztec-packages@6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](AztecProtocol/aztec-packages#7349)) ([586c0b0](AztecProtocol/aztec-packages@586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](AztecProtocol/aztec-packages#7354)) ([13e9b94](AztecProtocol/aztec-packages@13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Privacy leak in private refund ([#7358](AztecProtocol/aztec-packages#7358)) ([e05f6f0](AztecProtocol/aztec-packages@e05f6f0)), closes [#7321](AztecProtocol/aztec-packages#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) * **docs:** Fix link to docker ([#7395](AztecProtocol/aztec-packages#7395)) ([ad4a401](AztecProtocol/aztec-packages@ad4a401)) * **docs:** Update token tutorial ([#7241](AztecProtocol/aztec-packages#7241)) ([0414eb5](AztecProtocol/aztec-packages@0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Extracts refactoring of reading error payloads from [#5403](AztecProtocol/aztec-packages#5403) (noir-lang/noir#5413) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Generate declaration files for VKs ([#7391](AztecProtocol/aztec-packages#7391)) ([7c96636](AztecProtocol/aztec-packages@7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Notify Noir team on changes to the stdlib ([#7387](AztecProtocol/aztec-packages#7387)) ([061aac3](AztecProtocol/aztec-packages@061aac3)) * Optimize private call stack item hash for gate count ([#7285](AztecProtocol/aztec-packages#7285)) ([783d9b6](AztecProtocol/aztec-packages@783d9b6)) * Optimize public call stack item hashing ([#7330](AztecProtocol/aztec-packages#7330)) ([4a5093c](AztecProtocol/aztec-packages@4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](AztecProtocol/aztec-packages@8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](AztecProtocol/aztec-packages@9eb8d1c)) * Sync external contributions ([#6984](AztecProtocol/aztec-packages#6984)) ([a265b29](AztecProtocol/aztec-packages@a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](AztecProtocol/aztec-packages#7343)) ([533c937](AztecProtocol/aztec-packages@533c937)) * Update overview.md (fix link text) ([#7344](AztecProtocol/aztec-packages#7344)) ([79e5856](AztecProtocol/aztec-packages@79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

TomAFrench · 2024-07-16T16:11:24Z

This PR broke building the protocol circuits using earthly unless you have AWS credentials set up. @sirasistant can you update this so that missing credentials are non-blocking? We should be able to just fallback to generating the keys locally if no credentials are found.

sirasistant · 2024-07-17T07:36:53Z

I think there is no way for earthly to ignore missing secrets earthly/earthly#3262 so the options would be

Switch the AWS credentials to regular build args instead of earthly secrets so we can continue wether they are defined or not
Or if they must be an eartthly secret pass mock data

Do you think it'll be fine to switch the AWS credentials to be regular build args @ludamad ?
In any case of the two above I will need to pass the environment variable to disable the s3 cache DISABLE_VK_S3_CACHE

ludamad · 2024-07-17T12:21:46Z

We could pass empty secrets I guess

sirasistant added 12 commits June 5, 2024 15:42

feat: first implementation of vk tree

2895dbd

fix

ffd8f39

fix

3152f92

update vks to vkdata

9413ef5

adding vk tree root to tx context

72d114f

Merge branch 'master' into arv/constrained_vks

acb574d

vk tree verification

9209612

more changes to accomodate vk tree

4f25a89

fix padding txs

5d22817

remove logs

6b7c305

earthly test

8230f44

Merge branch 'master' into arv/constrained_vks

232ed0b

sirasistant added 15 commits June 27, 2024 09:46

Merge branch 'master' into arv/constrained_vks

d82ac6b

tsconfig

2e5eaa3

fmt

ce8665e

remove dependency cycle

a070098

fix

71ae9cb

revert webpack change

c3884ea

fix tsconfig

0ac3dd3

make sign type more concrete

9f1cf2b

fix test

7096d87

fix another test

c5c5592

fix visibility

9428140

fmt

06377c8

fixes for proving tests

965633b

Merge branch 'master' into arv/constrained_vks

c59bb12

fix integration l1 publisher test

881482f

fix prover client tests

290f807

sirasistant added 7 commits July 4, 2024 13:53

add secrets to missing gh actions

8a82a4e

fix ci.yml

4244e47

hopefully fix gates report

1ac4a29

Merge branch 'master' into arv/constrained_vks

9e9a174

fixes

8eac5b0

Merge branch 'arv/constrained_vks' of github.com:AztecProtocol/aztec-…

ffeaaa1

…packages into arv/constrained_vks

whitespace ):

3e33f52

sirasistant commented Jul 5, 2024

View reviewed changes

yarn-project/end-to-end/package.json Outdated Show resolved Hide resolved

sirasistant added 8 commits July 5, 2024 08:51

Update yarn-project/end-to-end/package.json

ad69061

fix test

fb1eed1

Merge branch 'arv/constrained_vks' of github.com:AztecProtocol/aztec-…

4b40d91

…packages into arv/constrained_vks

Merge branch 'master' into arv/constrained_vks

cae06fb

feat: remove vk tree root from calldata

9c49d63

artifact hash format

0c265bb

chore: update block result

5ce5c49

Merge branch 'master' into arv/constrained_vks

e6ae1fc

sirasistant changed the title ~~feat: VK tree (WIP)~~ feat: VK tree Jul 5, 2024

sirasistant requested a review from LeilaWang July 5, 2024 09:14

sirasistant marked this pull request as ready for review July 5, 2024 09:15

LeilaWang approved these changes Jul 6, 2024

View reviewed changes

Merge branch 'master' into arv/constrained_vks

e33c3cc

sirasistant merged commit 8631237 into master Jul 8, 2024
91 checks passed

sirasistant deleted the arv/constrained_vks branch July 8, 2024 09:26

AztecBot mentioned this pull request Jul 8, 2024

chore(master): Release 0.46.0 #7345

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: VK tree #6914

feat: VK tree #6914

sirasistant commented Jun 5, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

AztecBot commented Jun 27, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LeilaWang left a comment

TomAFrench commented Jul 16, 2024

sirasistant commented Jul 17, 2024

ludamad commented Jul 17, 2024

feat: VK tree #6914

feat: VK tree #6914

Conversation

sirasistant commented Jun 5, 2024 • edited Loading

github-actions bot commented Jun 26, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

AztecBot commented Jun 27, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LeilaWang left a comment

Choose a reason for hiding this comment

TomAFrench commented Jul 16, 2024

sirasistant commented Jul 17, 2024

ludamad commented Jul 17, 2024

sirasistant commented Jun 5, 2024 •

edited

Loading

github-actions bot commented Jun 26, 2024 •

edited

Loading

AztecBot commented Jun 27, 2024 •

edited

Loading