fix: false decryption fix #7066

benesjan · 2024-06-17T09:16:12Z

uses EventSelector in more places

Note: Had to revert computation of note type id in Noir so that it gets computed in rust again because of this issue.

benesjan · 2024-06-17T09:16:28Z

fix: false decryption fix #7066 👈
feat: throwing errors in buffer reader when out of bounds #7149
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

benesjan · 2024-06-17T10:33:01Z

noir/noir-repo/aztec_macros/src/transforms/note_interface.rs

@@ -528,7 +532,7 @@ fn generate_note_exports_global(
        global {0}_EXPORTS: (Field, str<{1}>) = ({2},\"{0}\");
        ",
        note_type,
-        note_type_id.len(),
+        note_type.len(),


Had to do this change as note_type_id no longer has the same length as note type.

benesjan · 2024-06-17T12:31:47Z

It's broken:

Compiling AddressNote for whatever reason results in an note type id which later on fails with parser error:

I tried increasing the note id size to 8 bytes from 4 and it fails and once again for the addressnote type id. And once again it's triggered by that specific note type id value (tried hardcoding it and it fails for all notes). If I tweak the value in any way, then it all compiles.
I also just tried taking the u32 value in the compute_note_type_id func and cast it to u64 with the same result.

For all the other contracts which don't use AddressNote there is no issue present.

benesjan · 2024-06-18T12:25:38Z

noir-projects/noir-contracts/contracts/uniswap_contract/src/main.nr

    #[aztec(public)]
    #[aztec(initializer)]
    fn constructor(portal_address: EthAddress) {
        storage.portal_address.initialize(portal_address);
    }
    // docs:end:uniswap_setup
-    
+


master was for some reson incorrectly formatted

benesjan · 2024-06-18T14:32:21Z

barretenberg/ts/src/types/fields.ts

@@ -15,7 +15,7 @@ export class Fr {
    const valueBigInt = typeof value === 'bigint' ? value : toBigIntBE(value);

    if (valueBigInt > Fr.MAX_VALUE) {
-      throw new Error(`Fr out of range: ${valueBigInt}`);
+      throw new Error(`Value 0x${valueBigInt.toString(16)} is greater or equal to field modulus.`);


Unified the message here with Fr from foundation package since I am checking the messages in tagged_log.ts. Would probably be good to tackle this one

benesjan · 2024-06-18T14:32:55Z

noir/noir-repo/compiler/noirc_driver/src/abi_gen.rs

-            HirLiteral::Integer(field, sign) => {
-                AbiValue::Integer { value: field.to_string(), sign }
-            }
+            HirLiteral::Integer(field, sign) => AbiValue::Integer { value: field.to_hex(), sign },


Fix from noir-lang/noir#5270

AztecBot · 2024-06-18T15:21:44Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:mint_public): 68.5 (-88%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 223 (+265%)
avm_simulation_time_ms (FPC:prepare_fee): 193 (+35%)
protocol_circuit_witness_generation_time_in_ms (private-kernel-tail-to-public): 8,017 (+16%)
protocol_circuit_witness_generation_time_in_ms (root-rollup): 84.6 (-39%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_30_ms	11,681 (-1%)	3,127 (-1%)	1,682 (+3%)	1,560 (-4%)	1,533 (+4%)
proof_construction_time_sha256_100_ms	43,617 (-1%)	11,732	5,400 (-1%)	5,374 (-1%)	5,328 (-1%)
proof_construction_time_poseidon_hash_ms	78.0 (+1%)	34.0 (-3%)	34.0 (-3%)	58.0 (+4%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,519	417	200	225	266
proof_construction_time_poseidon_hash_100_ms	5,754	1,573 (-1%)	726	764 (-3%)	795 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,466	9,452
l1_rollup_execution_gas	610,285	610,287	610,273
l2_block_processing_time_in_ms	746 (-1%)	1,402 (-1%)	2,743 (+2%)
l2_block_building_time_in_ms	25,246 (-2%)	51,155	99,774
l2_block_rollup_simulation_time_in_ms	25,246 (-2%)	51,155	99,774
l2_block_public_tx_process_time_in_ms	21,707 (-1%)	47,373	95,997

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,019	9,813
node_database_size_in_bytes	12,152,912	16,105,552
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	131 (+1%)	470 (+2%)	12,683 (-4%)	20,634	67,190	92,352	2,819	524,288
private-kernel-inner	394	950 (-6%)	49,325	94,902	67,190	92,352	2,819	2,097,152
private-kernel-tail	373 (-1%)	1,832 (+4%)	49,831 (-2%)	99,121	71,733	14,912	399	2,097,152
base-parity	6.12 (-6%)	1,964 (+5%)	2,756 (+1%)	128	64.0	2,208	2.00	131,072
root-parity	49.7 (-1%)	68.5 (-13%)	42,153 (+3%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,942	4,940 (+1%)	83,625 (+1%)	170,330	756	3,648	47.0	4,194,304
root-rollup	111 (-2%)	⚠️ 84.6 (-39%)	23,390 (-1%)	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	720 (+2%)	3,699 (+1%)	45,264	116,905	93,334	125,344	3,850	2,097,152
public-kernel-app-logic	616	4,681 (-3%)	46,750	116,905	93,334	125,344	3,850	2,097,152
public-kernel-tail	1,421 (+1%)	35,858 (-5%)	188,511 (+1%)	511,910	10,014	14,912	399	8,388,608
private-kernel-reset-small	596 (-1%)	2,022 (-9%)	45,464 (-2%)	123,313	67,190	92,352	2,819	2,097,152
public-kernel-teardown	617 (-1%)	4,703 (+1%)	46,192 (-2%)	116,905	93,334	125,344	3,850	2,097,152
merge-rollup	29.0	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	⚠️ 8,017 (+16%)	98,375	N/A	N/A	125,344	3,850	4,194,304

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	424 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	39.7 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,784	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	979	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,413 (-2%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,827 (-1%)	16,768	54,004 (-1%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,625 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	354 (+1%)	16,768	11,264 (-2%)	524,288	457
Token:transfer	1,312	9,944	4,484 (-10%)	16,768	47,474 (+3%)	2,097,152	457
AuthRegistry:set_authorized (avm)	21,043	N/A	N/A	87,200	1,382 (-6%)	N/A	N/A
FPC:prepare_fee (avm)	28,521	N/A	N/A	88,032	5,943 (+4%)	N/A	N/A
AuthRegistry:consume (avm)	34,973	N/A	N/A	87,616	2,985 (-5%)	N/A	N/A
Token:transfer_public (avm)	44,849	N/A	N/A	87,616	3,028 (-1%)	N/A	N/A
FPC:pay_refund (avm)	33,381	N/A	N/A	88,448	11,312 (+1%)	N/A	N/A
Benchmarking:create_note	1,344	9,944	1,407 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,944	73.5 (+1%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,694	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,644	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	66.2 (-4%)	13,873
GasToken:set_portal	16.9 (+3%)	3,495
Token:constructor	94.4 (+2%)	24,207
FPC:constructor	64.2 (+1%)	13,893
GasToken:mint_public	53.5 (-17%)	10,241
Token:mint_public	⚠️ 68.5 (-88%)	19,216
Token:assert_minter_and_mint	⚠️ 223 (+265%)	13,034
AuthRegistry:set_authorized	33.0 (-5%)	7,869
FPC:prepare_fee	⚠️ 193 (+35%)	15,187
Token:transfer_public	35.5 (+11%)	31,425
FPC:pay_refund	126 (-13%)	20,080
Benchmarking:increment_balance	2,697	15,465
Token:_increase_public_balance	67.7 (+18%)	15,089
FPC:pay_refund_with_shielded_rebate	141 (-2%)	21,167

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.158 (+3%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.7 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.601	0.514 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.5 (+1%)	76.3 (+1%)	131	244	480 (+3%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.496 (+1%)	0.469 (+1%)	0.450	0.443	0.448 (+2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.9 (+1%)	112 (+1%)	182 (-1%)	352	706 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.506 (+1%)	0.503 (+1%)	0.481 (-1%)	0.477	0.484 (+2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	73.0	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.520	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	85,672	670,983

Transaction size based on fee payment method

| Metric | |
| - | |

LHerskind

What is the reason that we don't just have a have a class extending the selector for the note type id when we have for the event and function selector?

Seems like it would be simpler to deal with the validity checks and all of that then 🤷

LHerskind · 2024-06-20T12:41:52Z

noir/noir-repo/aztec_macros/Cargo.toml

@@ -16,4 +16,4 @@ noirc_errors.workspace = true
 iter-extended.workspace = true
 convert_case = "0.6.0"
 regex = "1.10"
-
+tiny-keccak = { version = "2.0.0", features = ["keccak"] }


yarn-project/circuit-types/src/logs/l1_payload/l1_event_payload.ts

yarn-project/circuit-types/src/logs/l1_payload/l1_note_payload.ts

LHerskind

I'm curious how we ended up eating 💩 here while it did not have that issue in the event log case, guess there is somewhere that is breaking it a separate place? Looking forward to seeing fixed in a later pr, but I think this is still quite nice 👍

LHerskind · 2024-06-25T15:48:39Z

yarn-project/end-to-end/src/composed/e2e_aztec_js_browser.test.ts

 *       unexpectedly running in the background. Kill it with `killall chrome`
+ * NOTE 2: Don't forget to run `yarn build:web` once you make changes!


🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.44.0</summary> ## [0.44.0](aztec-package-v0.43.0...aztec-package-v0.44.0) (2024-06-26) ### Features * Add OpenTelemetry to node ([#7102](#7102)) ([6bf2b72](6bf2b72)) * Devnet deployments ([#7024](#7024)) ([fa70876](fa70876)) * Track spans ([#7129](#7129)) ([924c3f8](924c3f8)) </details> <details><summary>barretenberg.js: 0.44.0</summary> ## [0.44.0](barretenberg.js-v0.43.0...barretenberg.js-v0.44.0) (2024-06-26) ### Bug Fixes * False decryption fix ([#7066](#7066)) ([48d9df4](48d9df4)) </details> <details><summary>aztec-packages: 0.44.0</summary> ## [0.44.0](aztec-packages-v0.43.0...aztec-packages-v0.44.0) (2024-06-26) ### ⚠ BREAKING CHANGES * make note_getter return BoundedVec instead of an Option array ([#7050](#7050)) * TXE ([#6985](#6985)) ### Features * Add macro impls for events ([#7081](#7081)) ([c13dd9f](c13dd9f)) * Add OpenTelemetry to node ([#7102](#7102)) ([6bf2b72](6bf2b72)) * Added prove_output_all flow for honk ([#6869](#6869)) ([7bd7c66](7bd7c66)) * **avm:** Add ECC ops to avm_proving_test ([#7058](#7058)) ([7f62a90](7f62a90)) * **avm:** Cpp msm changes ([#7056](#7056)) ([f9c8f20](f9c8f20)) * **avm:** Include bb-pilcom in monorepo ([#7098](#7098)) ([0442158](0442158)) * Constrain event encryption and unify note and event emit api ([#7171](#7171)) ([5c3772f](5c3772f)), closes [#7160](#7160) * Conventional lookups using log-deriv ([#7020](#7020)) ([6f1212f](6f1212f)) * Devnet deployments ([#7024](#7024)) ([fa70876](fa70876)) * Do not discard logs on revert since the kernel has pruned revertible logs. ([#7076](#7076)) ([366fb21](366fb21)), closes [#4712](#4712) * **docs:** Publish PDF of protocol specs + remove links to pages in item lists in protocol specs ([#6684](#6684)) ([367e3cf](367e3cf)) * Enable merge recursive verifier in Goblin recursive verifier ([#7182](#7182)) ([9b4f56c](9b4f56c)) * Flamegraph helper script ([#7077](#7077)) ([8630c8f](8630c8f)) * Full test skips public simulation ([#7186](#7186)) ([4c1997f](4c1997f)) * Make note_getter return BoundedVec instead of an Option array ([#7050](#7050)) ([f9ac0fc](f9ac0fc)) * **p2p:** More comprehensive peer management, dial retries, persistence fix ([#6953](#6953)) ([cdd1cbd](cdd1cbd)) * Private authwit with static call ([#7073](#7073)) ([9c52d47](9c52d47)) * Several updates in SMT verification module ([#7105](#7105)) ([41b21f1](41b21f1)) * Shplonk revival in ECCVM ([#7164](#7164)) ([34eb5a0](34eb5a0)) * Throwing errors in `BufferReader` when out of bounds ([#7149](#7149)) ([bf4a986](bf4a986)) * Track spans ([#7129](#7129)) ([924c3f8](924c3f8)) * TXE ([#6985](#6985)) ([109624f](109624f)) * TXE 2: Electric boogaloo ([#7154](#7154)) ([bb38246](bb38246)) ### Bug Fixes * **avm:** Fix unencryptedlog c++ deser ([#7194](#7194)) ([89a99af](89a99af)) * **avm:** Re-enable ext call test ([#7147](#7147)) ([33ccf1b](33ccf1b)) * **avm:** Reenable tag error sload ([#7153](#7153)) ([fd92d46](fd92d46)) * **avm:** Update codegen ([#7178](#7178)) ([1d29708](1d29708)) * Bug fixing bench prover test ([#7135](#7135)) ([13678be](13678be)), closes [#7080](#7080) * **ci:** Don't run npm_deploy l1-contracts ([#7187](#7187)) ([80d26d8](80d26d8)) * **ci:** Move osxcross from build image ([#7151](#7151)) ([7746363](7746363)) * Enable log filtering with the DEBUG variable ([#7150](#7150)) ([33798b6](33798b6)) * Export event selector and replace function selector with event selector where appropriate ([#7095](#7095)) ([fcc15fa](fcc15fa)), closes [#7089](#7089) * False decryption fix ([#7066](#7066)) ([48d9df4](48d9df4)) * Fix bug for a unit test in full proving mode repated to MSM ([#7104](#7104)) ([e37809b](e37809b)) ### Miscellaneous * `destroy_note(...)` optimization ([#7103](#7103)) ([0770011](0770011)) * Add avm team as codeowners to more repo files ([#7196](#7196)) ([9be0ad6](9be0ad6)) * **avm:** Remove avm prefix from pil and executor ([#7099](#7099)) ([b502fcd](b502fcd)) * **avm:** Renamings and comments ([#7128](#7128)) ([ed2f98e](ed2f98e)) * **avm:** Separate some fixed tables ([#7163](#7163)) ([1d4a9a2](1d4a9a2)) * **ci:** Add new e2e base target ([#7179](#7179)) ([26fc599](26fc599)) * Create workflow for full AVM tests ([#7051](#7051)) ([a0b9c4b](a0b9c4b)), closes [#6643](#6643) * **docs:** Fix migration notes ([#7195](#7195)) ([88efda0](88efda0)) * **docs:** Moving tutorials and quick starts around, spinning off codespaces page ([#6777](#6777)) ([1542fa6](1542fa6)) * Fix migration notes ([#7133](#7133)) ([14917d3](14917d3)) * Fix noir-projects dockerfile for CircleCI ([#7093](#7093)) ([52ce25d](52ce25d)) * Increase the timeout of the runner for full AVM workflow to 70 minutes ([#7183](#7183)) ([9aabc32](9aabc32)) * Indirects and read/write slices ([#7082](#7082)) ([d5e80ee](d5e80ee)) * Note hashes cleanup + optimization ([#7132](#7132)) ([edd6d3f](edd6d3f)) * Note hashing gate optimizations ([#7130](#7130)) ([81a2580](81a2580)) * **powdr:** Update to latest and add logging ([#7152](#7152)) ([f500f2e](f500f2e)) * Reads the return data ([#6669](#6669)) ([ef85542](ef85542)) * Refactor AVM simulator's side-effect tracing ([#7091](#7091)) ([9495413](9495413)) * Remove stray files ([#7158](#7158)) ([29398de](29398de)) * Remove unneeded public input folding ([#7094](#7094)) ([c30dc38](c30dc38)) * Replace relative paths to noir-protocol-circuits ([f7e4392](f7e4392)) * Replace relative paths to noir-protocol-circuits ([886f7b1](886f7b1)) * Replace relative paths to noir-protocol-circuits ([b1081f8](b1081f8)) * Replace relative paths to noir-protocol-circuits ([c0989eb](c0989eb)) * Replace relative paths to noir-protocol-circuits ([525bbe7](525bbe7)) * Replace relative paths to noir-protocol-circuits ([67bcd82](67bcd82)) * Take the PCS out of Zeromorph and refactor tests ([#7078](#7078)) ([e192678](e192678)) * Track avm proving time ([#7084](#7084)) ([59df722](59df722)) * Ultra flavor cleanup ([#7070](#7070)) ([77761c6](77761c6)) </details> <details><summary>barretenberg: 0.44.0</summary> ## [0.44.0](barretenberg-v0.43.0...barretenberg-v0.44.0) (2024-06-26) ### Features * Added prove_output_all flow for honk ([#6869](#6869)) ([7bd7c66](7bd7c66)) * **avm:** Add ECC ops to avm_proving_test ([#7058](#7058)) ([7f62a90](7f62a90)) * **avm:** Cpp msm changes ([#7056](#7056)) ([f9c8f20](f9c8f20)) * **avm:** Include bb-pilcom in monorepo ([#7098](#7098)) ([0442158](0442158)) * Conventional lookups using log-deriv ([#7020](#7020)) ([6f1212f](6f1212f)) * Enable merge recursive verifier in Goblin recursive verifier ([#7182](#7182)) ([9b4f56c](9b4f56c)) * Several updates in SMT verification module ([#7105](#7105)) ([41b21f1](41b21f1)) * Shplonk revival in ECCVM ([#7164](#7164)) ([34eb5a0](34eb5a0)) ### Bug Fixes * **avm:** Fix unencryptedlog c++ deser ([#7194](#7194)) ([89a99af](89a99af)) * **avm:** Re-enable ext call test ([#7147](#7147)) ([33ccf1b](33ccf1b)) * **avm:** Reenable tag error sload ([#7153](#7153)) ([fd92d46](fd92d46)) * **avm:** Update codegen ([#7178](#7178)) ([1d29708](1d29708)) * Bug fixing bench prover test ([#7135](#7135)) ([13678be](13678be)), closes [#7080](#7080) * Fix bug for a unit test in full proving mode repated to MSM ([#7104](#7104)) ([e37809b](e37809b)) ### Miscellaneous * **avm:** Remove avm prefix from pil and executor ([#7099](#7099)) ([b502fcd](b502fcd)) * **avm:** Renamings and comments ([#7128](#7128)) ([ed2f98e](ed2f98e)) * **avm:** Separate some fixed tables ([#7163](#7163)) ([1d4a9a2](1d4a9a2)) * Create workflow for full AVM tests ([#7051](#7051)) ([a0b9c4b](a0b9c4b)), closes [#6643](#6643) * Indirects and read/write slices ([#7082](#7082)) ([d5e80ee](d5e80ee)) * Reads the return data ([#6669](#6669)) ([ef85542](ef85542)) * Remove unneeded public input folding ([#7094](#7094)) ([c30dc38](c30dc38)) * Take the PCS out of Zeromorph and refactor tests ([#7078](#7078)) ([e192678](e192678)) * Ultra flavor cleanup ([#7070](#7070)) ([77761c6](77761c6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.44.0</summary> ## [0.44.0](AztecProtocol/aztec-packages@aztec-package-v0.43.0...aztec-package-v0.44.0) (2024-06-26) ### Features * Add OpenTelemetry to node ([#7102](AztecProtocol/aztec-packages#7102)) ([6bf2b72](AztecProtocol/aztec-packages@6bf2b72)) * Devnet deployments ([#7024](AztecProtocol/aztec-packages#7024)) ([fa70876](AztecProtocol/aztec-packages@fa70876)) * Track spans ([#7129](AztecProtocol/aztec-packages#7129)) ([924c3f8](AztecProtocol/aztec-packages@924c3f8)) </details> <details><summary>barretenberg.js: 0.44.0</summary> ## [0.44.0](AztecProtocol/aztec-packages@barretenberg.js-v0.43.0...barretenberg.js-v0.44.0) (2024-06-26) ### Bug Fixes * False decryption fix ([#7066](AztecProtocol/aztec-packages#7066)) ([48d9df4](AztecProtocol/aztec-packages@48d9df4)) </details> <details><summary>aztec-packages: 0.44.0</summary> ## [0.44.0](AztecProtocol/aztec-packages@aztec-packages-v0.43.0...aztec-packages-v0.44.0) (2024-06-26) ### ⚠ BREAKING CHANGES * make note_getter return BoundedVec instead of an Option array ([#7050](AztecProtocol/aztec-packages#7050)) * TXE ([#6985](AztecProtocol/aztec-packages#6985)) ### Features * Add macro impls for events ([#7081](AztecProtocol/aztec-packages#7081)) ([c13dd9f](AztecProtocol/aztec-packages@c13dd9f)) * Add OpenTelemetry to node ([#7102](AztecProtocol/aztec-packages#7102)) ([6bf2b72](AztecProtocol/aztec-packages@6bf2b72)) * Added prove_output_all flow for honk ([#6869](AztecProtocol/aztec-packages#6869)) ([7bd7c66](AztecProtocol/aztec-packages@7bd7c66)) * **avm:** Add ECC ops to avm_proving_test ([#7058](AztecProtocol/aztec-packages#7058)) ([7f62a90](AztecProtocol/aztec-packages@7f62a90)) * **avm:** Cpp msm changes ([#7056](AztecProtocol/aztec-packages#7056)) ([f9c8f20](AztecProtocol/aztec-packages@f9c8f20)) * **avm:** Include bb-pilcom in monorepo ([#7098](AztecProtocol/aztec-packages#7098)) ([0442158](AztecProtocol/aztec-packages@0442158)) * Constrain event encryption and unify note and event emit api ([#7171](AztecProtocol/aztec-packages#7171)) ([5c3772f](AztecProtocol/aztec-packages@5c3772f)), closes [#7160](AztecProtocol/aztec-packages#7160) * Conventional lookups using log-deriv ([#7020](AztecProtocol/aztec-packages#7020)) ([6f1212f](AztecProtocol/aztec-packages@6f1212f)) * Devnet deployments ([#7024](AztecProtocol/aztec-packages#7024)) ([fa70876](AztecProtocol/aztec-packages@fa70876)) * Do not discard logs on revert since the kernel has pruned revertible logs. ([#7076](AztecProtocol/aztec-packages#7076)) ([366fb21](AztecProtocol/aztec-packages@366fb21)), closes [#4712](AztecProtocol/aztec-packages#4712) * **docs:** Publish PDF of protocol specs + remove links to pages in item lists in protocol specs ([#6684](AztecProtocol/aztec-packages#6684)) ([367e3cf](AztecProtocol/aztec-packages@367e3cf)) * Enable merge recursive verifier in Goblin recursive verifier ([#7182](AztecProtocol/aztec-packages#7182)) ([9b4f56c](AztecProtocol/aztec-packages@9b4f56c)) * Flamegraph helper script ([#7077](AztecProtocol/aztec-packages#7077)) ([8630c8f](AztecProtocol/aztec-packages@8630c8f)) * Full test skips public simulation ([#7186](AztecProtocol/aztec-packages#7186)) ([4c1997f](AztecProtocol/aztec-packages@4c1997f)) * Make note_getter return BoundedVec instead of an Option array ([#7050](AztecProtocol/aztec-packages#7050)) ([f9ac0fc](AztecProtocol/aztec-packages@f9ac0fc)) * **p2p:** More comprehensive peer management, dial retries, persistence fix ([#6953](AztecProtocol/aztec-packages#6953)) ([cdd1cbd](AztecProtocol/aztec-packages@cdd1cbd)) * Private authwit with static call ([#7073](AztecProtocol/aztec-packages#7073)) ([9c52d47](AztecProtocol/aztec-packages@9c52d47)) * Several updates in SMT verification module ([#7105](AztecProtocol/aztec-packages#7105)) ([41b21f1](AztecProtocol/aztec-packages@41b21f1)) * Shplonk revival in ECCVM ([#7164](AztecProtocol/aztec-packages#7164)) ([34eb5a0](AztecProtocol/aztec-packages@34eb5a0)) * Throwing errors in `BufferReader` when out of bounds ([#7149](AztecProtocol/aztec-packages#7149)) ([bf4a986](AztecProtocol/aztec-packages@bf4a986)) * Track spans ([#7129](AztecProtocol/aztec-packages#7129)) ([924c3f8](AztecProtocol/aztec-packages@924c3f8)) * TXE ([#6985](AztecProtocol/aztec-packages#6985)) ([109624f](AztecProtocol/aztec-packages@109624f)) * TXE 2: Electric boogaloo ([#7154](AztecProtocol/aztec-packages#7154)) ([bb38246](AztecProtocol/aztec-packages@bb38246)) ### Bug Fixes * **avm:** Fix unencryptedlog c++ deser ([#7194](AztecProtocol/aztec-packages#7194)) ([89a99af](AztecProtocol/aztec-packages@89a99af)) * **avm:** Re-enable ext call test ([#7147](AztecProtocol/aztec-packages#7147)) ([33ccf1b](AztecProtocol/aztec-packages@33ccf1b)) * **avm:** Reenable tag error sload ([#7153](AztecProtocol/aztec-packages#7153)) ([fd92d46](AztecProtocol/aztec-packages@fd92d46)) * **avm:** Update codegen ([#7178](AztecProtocol/aztec-packages#7178)) ([1d29708](AztecProtocol/aztec-packages@1d29708)) * Bug fixing bench prover test ([#7135](AztecProtocol/aztec-packages#7135)) ([13678be](AztecProtocol/aztec-packages@13678be)), closes [#7080](AztecProtocol/aztec-packages#7080) * **ci:** Don't run npm_deploy l1-contracts ([#7187](AztecProtocol/aztec-packages#7187)) ([80d26d8](AztecProtocol/aztec-packages@80d26d8)) * **ci:** Move osxcross from build image ([#7151](AztecProtocol/aztec-packages#7151)) ([7746363](AztecProtocol/aztec-packages@7746363)) * Enable log filtering with the DEBUG variable ([#7150](AztecProtocol/aztec-packages#7150)) ([33798b6](AztecProtocol/aztec-packages@33798b6)) * Export event selector and replace function selector with event selector where appropriate ([#7095](AztecProtocol/aztec-packages#7095)) ([fcc15fa](AztecProtocol/aztec-packages@fcc15fa)), closes [#7089](AztecProtocol/aztec-packages#7089) * False decryption fix ([#7066](AztecProtocol/aztec-packages#7066)) ([48d9df4](AztecProtocol/aztec-packages@48d9df4)) * Fix bug for a unit test in full proving mode repated to MSM ([#7104](AztecProtocol/aztec-packages#7104)) ([e37809b](AztecProtocol/aztec-packages@e37809b)) ### Miscellaneous * `destroy_note(...)` optimization ([#7103](AztecProtocol/aztec-packages#7103)) ([0770011](AztecProtocol/aztec-packages@0770011)) * Add avm team as codeowners to more repo files ([#7196](AztecProtocol/aztec-packages#7196)) ([9be0ad6](AztecProtocol/aztec-packages@9be0ad6)) * **avm:** Remove avm prefix from pil and executor ([#7099](AztecProtocol/aztec-packages#7099)) ([b502fcd](AztecProtocol/aztec-packages@b502fcd)) * **avm:** Renamings and comments ([#7128](AztecProtocol/aztec-packages#7128)) ([ed2f98e](AztecProtocol/aztec-packages@ed2f98e)) * **avm:** Separate some fixed tables ([#7163](AztecProtocol/aztec-packages#7163)) ([1d4a9a2](AztecProtocol/aztec-packages@1d4a9a2)) * **ci:** Add new e2e base target ([#7179](AztecProtocol/aztec-packages#7179)) ([26fc599](AztecProtocol/aztec-packages@26fc599)) * Create workflow for full AVM tests ([#7051](AztecProtocol/aztec-packages#7051)) ([a0b9c4b](AztecProtocol/aztec-packages@a0b9c4b)), closes [#6643](AztecProtocol/aztec-packages#6643) * **docs:** Fix migration notes ([#7195](AztecProtocol/aztec-packages#7195)) ([88efda0](AztecProtocol/aztec-packages@88efda0)) * **docs:** Moving tutorials and quick starts around, spinning off codespaces page ([#6777](AztecProtocol/aztec-packages#6777)) ([1542fa6](AztecProtocol/aztec-packages@1542fa6)) * Fix migration notes ([#7133](AztecProtocol/aztec-packages#7133)) ([14917d3](AztecProtocol/aztec-packages@14917d3)) * Fix noir-projects dockerfile for CircleCI ([#7093](AztecProtocol/aztec-packages#7093)) ([52ce25d](AztecProtocol/aztec-packages@52ce25d)) * Increase the timeout of the runner for full AVM workflow to 70 minutes ([#7183](AztecProtocol/aztec-packages#7183)) ([9aabc32](AztecProtocol/aztec-packages@9aabc32)) * Indirects and read/write slices ([#7082](AztecProtocol/aztec-packages#7082)) ([d5e80ee](AztecProtocol/aztec-packages@d5e80ee)) * Note hashes cleanup + optimization ([#7132](AztecProtocol/aztec-packages#7132)) ([edd6d3f](AztecProtocol/aztec-packages@edd6d3f)) * Note hashing gate optimizations ([#7130](AztecProtocol/aztec-packages#7130)) ([81a2580](AztecProtocol/aztec-packages@81a2580)) * **powdr:** Update to latest and add logging ([#7152](AztecProtocol/aztec-packages#7152)) ([f500f2e](AztecProtocol/aztec-packages@f500f2e)) * Reads the return data ([#6669](AztecProtocol/aztec-packages#6669)) ([ef85542](AztecProtocol/aztec-packages@ef85542)) * Refactor AVM simulator's side-effect tracing ([#7091](AztecProtocol/aztec-packages#7091)) ([9495413](AztecProtocol/aztec-packages@9495413)) * Remove stray files ([#7158](AztecProtocol/aztec-packages#7158)) ([29398de](AztecProtocol/aztec-packages@29398de)) * Remove unneeded public input folding ([#7094](AztecProtocol/aztec-packages#7094)) ([c30dc38](AztecProtocol/aztec-packages@c30dc38)) * Replace relative paths to noir-protocol-circuits ([f7e4392](AztecProtocol/aztec-packages@f7e4392)) * Replace relative paths to noir-protocol-circuits ([886f7b1](AztecProtocol/aztec-packages@886f7b1)) * Replace relative paths to noir-protocol-circuits ([b1081f8](AztecProtocol/aztec-packages@b1081f8)) * Replace relative paths to noir-protocol-circuits ([c0989eb](AztecProtocol/aztec-packages@c0989eb)) * Replace relative paths to noir-protocol-circuits ([525bbe7](AztecProtocol/aztec-packages@525bbe7)) * Replace relative paths to noir-protocol-circuits ([67bcd82](AztecProtocol/aztec-packages@67bcd82)) * Take the PCS out of Zeromorph and refactor tests ([#7078](AztecProtocol/aztec-packages#7078)) ([e192678](AztecProtocol/aztec-packages@e192678)) * Track avm proving time ([#7084](AztecProtocol/aztec-packages#7084)) ([59df722](AztecProtocol/aztec-packages@59df722)) * Ultra flavor cleanup ([#7070](AztecProtocol/aztec-packages#7070)) ([77761c6](AztecProtocol/aztec-packages@77761c6)) </details> <details><summary>barretenberg: 0.44.0</summary> ## [0.44.0](AztecProtocol/aztec-packages@barretenberg-v0.43.0...barretenberg-v0.44.0) (2024-06-26) ### Features * Added prove_output_all flow for honk ([#6869](AztecProtocol/aztec-packages#6869)) ([7bd7c66](AztecProtocol/aztec-packages@7bd7c66)) * **avm:** Add ECC ops to avm_proving_test ([#7058](AztecProtocol/aztec-packages#7058)) ([7f62a90](AztecProtocol/aztec-packages@7f62a90)) * **avm:** Cpp msm changes ([#7056](AztecProtocol/aztec-packages#7056)) ([f9c8f20](AztecProtocol/aztec-packages@f9c8f20)) * **avm:** Include bb-pilcom in monorepo ([#7098](AztecProtocol/aztec-packages#7098)) ([0442158](AztecProtocol/aztec-packages@0442158)) * Conventional lookups using log-deriv ([#7020](AztecProtocol/aztec-packages#7020)) ([6f1212f](AztecProtocol/aztec-packages@6f1212f)) * Enable merge recursive verifier in Goblin recursive verifier ([#7182](AztecProtocol/aztec-packages#7182)) ([9b4f56c](AztecProtocol/aztec-packages@9b4f56c)) * Several updates in SMT verification module ([#7105](AztecProtocol/aztec-packages#7105)) ([41b21f1](AztecProtocol/aztec-packages@41b21f1)) * Shplonk revival in ECCVM ([#7164](AztecProtocol/aztec-packages#7164)) ([34eb5a0](AztecProtocol/aztec-packages@34eb5a0)) ### Bug Fixes * **avm:** Fix unencryptedlog c++ deser ([#7194](AztecProtocol/aztec-packages#7194)) ([89a99af](AztecProtocol/aztec-packages@89a99af)) * **avm:** Re-enable ext call test ([#7147](AztecProtocol/aztec-packages#7147)) ([33ccf1b](AztecProtocol/aztec-packages@33ccf1b)) * **avm:** Reenable tag error sload ([#7153](AztecProtocol/aztec-packages#7153)) ([fd92d46](AztecProtocol/aztec-packages@fd92d46)) * **avm:** Update codegen ([#7178](AztecProtocol/aztec-packages#7178)) ([1d29708](AztecProtocol/aztec-packages@1d29708)) * Bug fixing bench prover test ([#7135](AztecProtocol/aztec-packages#7135)) ([13678be](AztecProtocol/aztec-packages@13678be)), closes [#7080](AztecProtocol/aztec-packages#7080) * Fix bug for a unit test in full proving mode repated to MSM ([#7104](AztecProtocol/aztec-packages#7104)) ([e37809b](AztecProtocol/aztec-packages@e37809b)) ### Miscellaneous * **avm:** Remove avm prefix from pil and executor ([#7099](AztecProtocol/aztec-packages#7099)) ([b502fcd](AztecProtocol/aztec-packages@b502fcd)) * **avm:** Renamings and comments ([#7128](AztecProtocol/aztec-packages#7128)) ([ed2f98e](AztecProtocol/aztec-packages@ed2f98e)) * **avm:** Separate some fixed tables ([#7163](AztecProtocol/aztec-packages#7163)) ([1d4a9a2](AztecProtocol/aztec-packages@1d4a9a2)) * Create workflow for full AVM tests ([#7051](AztecProtocol/aztec-packages#7051)) ([a0b9c4b](AztecProtocol/aztec-packages@a0b9c4b)), closes [#6643](AztecProtocol/aztec-packages#6643) * Indirects and read/write slices ([#7082](AztecProtocol/aztec-packages#7082)) ([d5e80ee](AztecProtocol/aztec-packages@d5e80ee)) * Reads the return data ([#6669](AztecProtocol/aztec-packages#6669)) ([ef85542](AztecProtocol/aztec-packages@ef85542)) * Remove unneeded public input folding ([#7094](AztecProtocol/aztec-packages#7094)) ([c30dc38](AztecProtocol/aztec-packages@c30dc38)) * Take the PCS out of Zeromorph and refactor tests ([#7078](AztecProtocol/aztec-packages#7078)) ([e192678](AztecProtocol/aztec-packages@e192678)) * Ultra flavor cleanup ([#7070](AztecProtocol/aztec-packages#7070)) ([77761c6](AztecProtocol/aztec-packages@77761c6)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

benesjan commented Jun 17, 2024

View reviewed changes

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 3 times, most recently from c7c7b3c to 12ddea2 Compare June 18, 2024 11:49

benesjan commented Jun 18, 2024

View reviewed changes

benesjan marked this pull request as ready for review June 18, 2024 14:35

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 2 times, most recently from d756c45 to d221bbc Compare June 18, 2024 17:54

benesjan requested a review from LHerskind June 18, 2024 19:51

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 3 times, most recently from 479d882 to 0cfac4b Compare June 20, 2024 08:43

LHerskind requested changes Jun 21, 2024

View reviewed changes

LHerskind mentioned this pull request Jun 21, 2024

feat: add macro impls for events #7081

Merged

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 2 times, most recently from 3c1b89d to 8446047 Compare June 24, 2024 07:10

benesjan changed the base branch from master to 06-21-feat_throwing_errors_in_buffer_reader_when_out_of_bounds June 24, 2024 07:10

benesjan mentioned this pull request Jun 24, 2024

feat: throwing errors in buffer reader when out of bounds #7149

Merged

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 2 times, most recently from 908f5a2 to 6263276 Compare June 24, 2024 08:42

benesjan force-pushed the 06-21-feat_throwing_errors_in_buffer_reader_when_out_of_bounds branch from c542389 to 1050840 Compare June 24, 2024 09:34

benesjan force-pushed the 06-17-fix_false_decryption_fix branch from 6263276 to f32eccd Compare June 24, 2024 09:36

Base automatically changed from 06-21-feat_throwing_errors_in_buffer_reader_when_out_of_bounds to master June 24, 2024 10:04

benesjan force-pushed the 06-17-fix_false_decryption_fix branch from f32eccd to 04a601b Compare June 24, 2024 10:40

benesjan mentioned this pull request Jun 24, 2024

Compute note type id in Noir instead of Rust #7165

Closed

benesjan force-pushed the 06-17-fix_false_decryption_fix branch 2 times, most recently from 6eea485 to 501125a Compare June 25, 2024 11:27

benesjan requested a review from LHerskind June 25, 2024 13:28

LHerskind approved these changes Jun 25, 2024

View reviewed changes

benesjan added 9 commits June 26, 2024 07:10

fix: false decryption fix

3533ab3

reverting noir computation of note type id

23710b4

fix

a623fe6

comment fix

842fce8

cleanup

0adee5c

serialization fix 1

2a34bd5

fromJSON

faf34ce

comment

b94de06

fmt

e89c4a6

benesjan force-pushed the 06-17-fix_false_decryption_fix branch from 0390fd2 to e89c4a6 Compare June 26, 2024 07:20

benesjan enabled auto-merge (squash) June 26, 2024 07:21

benesjan merged commit 48d9df4 into master Jun 26, 2024
91 checks passed

benesjan deleted the 06-17-fix_false_decryption_fix branch June 26, 2024 08:22

This was referenced Jun 26, 2024

chore(master): Release 0.44.0 #7088

Merged

feat: Sync from aztec-packages noir-lang/noir#5340

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: false decryption fix #7066

fix: false decryption fix #7066

benesjan commented Jun 17, 2024 •

edited

Loading

benesjan commented Jun 17, 2024 •

edited

Loading

benesjan Jun 17, 2024

benesjan commented Jun 17, 2024

benesjan Jun 18, 2024

benesjan Jun 18, 2024

benesjan Jun 18, 2024 •

edited

Loading

AztecBot commented Jun 18, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind left a comment

LHerskind Jun 20, 2024

LHerskind left a comment

LHerskind Jun 25, 2024

		* unexpectedly running in the background. Kill it with `killall chrome`
		* NOTE 2: Don't forget to run `yarn build:web` once you make changes!

fix: false decryption fix #7066

fix: false decryption fix #7066

Conversation

benesjan commented Jun 17, 2024 • edited Loading

benesjan commented Jun 17, 2024 • edited Loading

benesjan Jun 17, 2024

Choose a reason for hiding this comment

benesjan commented Jun 17, 2024

benesjan Jun 18, 2024

Choose a reason for hiding this comment

benesjan Jun 18, 2024

Choose a reason for hiding this comment

benesjan Jun 18, 2024 • edited Loading

Choose a reason for hiding this comment

AztecBot commented Jun 18, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind Jun 20, 2024

Choose a reason for hiding this comment

LHerskind left a comment

Choose a reason for hiding this comment

LHerskind Jun 25, 2024

Choose a reason for hiding this comment

benesjan commented Jun 17, 2024 •

edited

Loading

benesjan commented Jun 17, 2024 •

edited

Loading

benesjan Jun 18, 2024 •

edited

Loading

AztecBot commented Jun 18, 2024 •

edited

Loading