refactor: indirects and read/write slices

[IlyasRidhuan]

This PR does a few things to clean up the indirect and mem handling in the avm trace.

1. Adds support to resolve indirects across all operands in a similar way to the simulator.
2. Introduces the constrained_read and constrained_write mem abstractions that handle the (potential) indirect load step without needing to manually write them.
3. Indirect handling in the write_slice and read_slice helpers.
4. Clean up gadgets read/write cycle - dropping unnecessary reads of indirect destination offset thanks to above point
5. Simplified gadgets execution tests, removed checks other than return result since they were arbitrary based on our read pattern at the time and not reflective of what the tests should look like when they are constrained.

Note the CMOV, MOV and JUMPI have been left for a later refactor as they use specific load patterns in the mem trace, plus this PR was getting large..

[IlyasRidhuan]

• fix(avm): reenable tag error sload #7153
• fix(avm): re-enable ext call test #7147
• refactor: indirects and read/write slices #7082 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,457 (-20%)
• avm_simulation_time_ms (Token:mint_public): 91.7 (-86%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 213 (+180%)
• avm_simulation_time_ms (FPC:pay_refund_with_shielded_rebate): 100 (-35%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_30_ms	11,525 (+1%)	3,108	⚠️ 1,457 (-20%)	1,423 (-8%)	1,465
proof_construction_time_sha256_100_ms	45,566 (+2%)	12,366 (+2%)	5,766 (+1%)	5,680 (+1%)	5,538
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	57.0 (-2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,534 (+1%)	422 (+1%)	203	226	268
proof_construction_time_poseidon_hash_100_ms	5,806 (+1%)	1,594 (+2%)	727	797 (+5%)	799

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,452	9,470	9,464
l1_rollup_execution_gas	610,273	610,291	610,285
l2_block_processing_time_in_ms	757 (-4%)	1,397 (-1%)	2,725
l2_block_building_time_in_ms	25,239 (-1%)	51,231	99,252 (-1%)
l2_block_rollup_simulation_time_in_ms	25,146 (-1%)	50,929	98,902 (-1%)
l2_block_public_tx_process_time_in_ms	21,600 (-1%)	47,155	95,191 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	6,918 (-1%)	9,767 (-1%)
node_database_size_in_bytes	12,185,680	16,089,168
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	129 (-1%)	526 (+6%)	12,174 (-1%)	20,634	67,190	92,352	2,819	524,288
private-kernel-inner	393 (-1%)	1,038 (+2%)	44,739	94,902	67,190	92,352	2,819	2,097,152
private-kernel-tail	371 (-1%)	1,880	45,945	99,121	71,733	14,912	399	2,097,152
base-parity	6.34 (+2%)	1,968 (-1%)	2,530 (-2%)	128	64.0	2,208	2.00	131,072
root-parity	50.1 (+1%)	46.8 (-5%)	33,709 (-2%)	27,100	64.0	2,720	18.0	2,097,152
base-rollup	7,913	4,348	71,872	170,330	756	3,648	47.0	4,194,304
root-rollup	113 (+1%)	63.5 (-4%)	19,584	25,309	620	3,456	41.0	1,048,576
public-kernel-setup	718 (-1%)	3,166	38,671	116,905	93,334	125,344	3,850	2,097,152
public-kernel-app-logic	612 (-1%)	4,173	40,417 (+2%)	116,905	93,334	125,344	3,850	2,097,152
public-kernel-tail	1,419	32,167 (+8%)	165,389 (-1%)	511,910	10,014	14,912	399	8,388,608
private-kernel-reset-small	593 (-1%)	2,066 (-3%)	40,873 (-1%)	123,313	67,190	92,352	2,819	2,097,152
public-kernel-teardown	614 (-1%)	4,206 (+1%)	40,474 (+1%)	116,905	93,334	125,344	3,850	2,097,152
merge-rollup	28.8	N/A	N/A	16,542	756	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	7,348 (-1%)	84,738 (+1%)	N/A	N/A	125,344	3,850	4,194,304

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	405	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	40.8	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,802	N/A	N/A	N/A	N/A
GasToken:deploy	1,376	9,944	987 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,458	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,863 (+1%)	16,768	50,738 (-1%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,743 (+1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	377	16,768	10,188 (-2%)	524,288	457
Token:transfer	1,312	9,944	4,526	16,768	41,311 (-1%)	2,097,152	457
AuthRegistry:set_authorized (avm)	21,043	N/A	N/A	87,200	1,621 (-3%)	N/A	N/A
FPC:prepare_fee (avm)	28,841	N/A	N/A	88,032	4,772	N/A	N/A
Token:transfer_public (avm)	44,971	N/A	N/A	87,865	4,042 (-1%)	N/A	N/A
AuthRegistry:consume (avm)	34,973	N/A	N/A	87,616	2,822	N/A	N/A
FPC:pay_refund (avm)	33,573	N/A	N/A	88,448	8,894	N/A	N/A
Benchmarking:create_note	1,344	9,944	1,431 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,280	9,944	73.7	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,598 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,541 (-1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	67.5 (-4%)	13,873
GasToken:set_portal	16.6 (+7%)	3,495
Token:constructor	94.8	24,207
FPC:constructor	62.6 (+1%)	13,893
GasToken:mint_public	53.3	10,241
Token:mint_public	⚠️ 91.7 (-86%)	19,216
Token:assert_minter_and_mint	⚠️ 213 (+180%)	13,034
AuthRegistry:set_authorized	32.5 (-9%)	7,869
FPC:prepare_fee	167 (-8%)	15,187
Token:transfer_public	37.0 (-18%)	31,425
FPC:pay_refund	122 (+3%)	20,080
Benchmarking:increment_balance	2,685	15,465
Token:_increase_public_balance	61.2 (+2%)	15,089
FPC:pay_refund_with_shielded_rebate	⚠️ 100 (-35%)	21,167

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.175

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.602	0.518	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	48.4	75.9	130 (-2%)	243	471 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.494 (-1%)	0.466	0.447 (-1%)	0.441	0.440 (-1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.6	111	181 (-1%)	350 (-1%)	694 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.505	0.498	0.480 (-1%)	0.475	0.476 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.518	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	85,672	670,983

Transaction size based on fee payment method

| Metric | |
| - | |

[AztecBot]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite	Current: 3500c30	Previous: a76ed66	Ratio
wasmClientIVCBench/Full/6	53188.84985600001 ms/iter	49818.34289000001 ms/iter	1.07
Goblin::merge(t)	222542173 ns/iter	197523536 ns/iter	1.13

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

[fcarreiro]

Overall a welcome change! I've only looked at the high level idea. I'll let Jean approve.

[jeanmon]

Great refactoring! Please look at the comments before merging.