refactor: counters #7342

LeilaWang · 2024-07-04T13:38:22Z

Check min_revertible_side_effect_counter against private call requests emitted from any private function.
Enforce min_revertible_side_effect_counter to be set when running private_tail_to_public.
Remove side_efffect_counter from call_context and simply refer to the start_side_effect_counter in the private circuit public inputs.

AztecBot · 2024-07-04T14:15:11Z

Benchmark results

Metrics with a significant change:

avm_simulation_time_ms (Token:transfer_public): 26.8 (-30%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,713 (-1%)	1,540 (-1%)	699 (-1%)	760 (-1%)	767
proof_construction_time_sha256_30_ms	11,726 (-1%)	3,131 (-2%)	1,397 (-1%)	1,428 (-1%)	1,461 (-1%)
proof_construction_time_sha256_100_ms	43,756 (-1%)	11,715 (-1%)	6,529 (+7%)	5,406	5,362 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	38.0 (+9%)	34.0	59.0 (+5%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,513 (-1%)	414 (-1%)	202	228 (-3%)	268 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,730 (-1%)	1,574 (-1%)	724 (-1%)	776 (-1%)	798 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,472	9,464
l1_rollup_execution_gas	613,492	613,651	613,794
l2_block_processing_time_in_ms	759	1,405	2,716
l2_block_building_time_in_ms	12,924 (+1%)	25,544	49,902
l2_block_rollup_simulation_time_in_ms	12,924 (+1%)	25,544	49,902
l2_block_public_tx_process_time_in_ms	10,860 (+1%)	23,323	47,659

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,013 (+1%)	9,747 (-2%)
node_database_size_in_bytes	12,410,960	16,195,664
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	108 (-1%)	404 (+3%)	14,607 (-2%)	20,002	55,022	74,208	2,252	524,288
private-kernel-inner	220	693 (+1%)	28,404 (-5%)	82,134	55,022	74,208	2,252	1,048,576
private-kernel-tail	1,054	2,454 (+2%)	54,280 (-1%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.22	905 (+5%)	2,619 (-1%)	160	96.0	2,240	3.00	131,072
root-parity	69.7 (+1%)	73.7 (+1%)	41,991 (+3%)	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,135	4,960 (+4%)	92,114 (+2%)	172,028	632	3,552	44.0	4,194,304
root-rollup	126 (+1%)	90.1 (+5%)	23,541	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	187 (-1%)	2,365	41,035 (-6%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-app-logic	144 (-1%)	3,342 (+2%)	43,282 (-2%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-tail	890	23,425 (-4%)	188,927 (+4%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	291 (+1%)	1,269 (+15%)	26,648 (+4%)	79,273	55,022	74,208	2,252	1,048,576
public-kernel-teardown	133 (-1%)	3,320 (+1%)	41,668 (+1%)	103,911	80,310	106,944	3,275	2,097,152
merge-rollup	40.0 (-1%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	8,477	58,318 (-2%)	N/A	N/A	106,944	3,275	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312 (-2%)	9,344	392 (-1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376 (-2%)	9,344	24.3 (-1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888 (-2%)	9,344	645 (-1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344 (-2%)	9,344	551 (-4%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280 (-2%)	9,344	474	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272 (-1%)	9,344	817	15,840 (-1%)	4,624 (-2%)	131,072	428 (-1%)
Token:privately_mint_private_note	1,248 (-2%)	9,344	535 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312 (-2%)	9,344	100	15,840 (-1%)	1,698 (-1%)	65,536	428 (-1%)
Token:transfer	1,280 (-2%)	9,344	1,610	15,840 (-1%)	11,394 (-2%)	524,288	428 (-1%)
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,261 (-6%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	2,656 (-15%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	3,800 (-5%)	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	2,633 (-8%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	23,796 (-2%)	N/A	N/A
Benchmarking:create_note	1,312 (-2%)	9,344	463 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248 (-2%)	9,344	41.1	N/A	N/A	N/A	N/A
Token:unshield	1,344 (-2%)	9,344	1,326	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344 (-2%)	9,344	1,713	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	76.9 (-5%)	13,790
GasToken:set_portal	15.9 (-5%)	3,339
Token:constructor	103 (+3%)	23,692
FPC:constructor	74.0	13,592
GasToken:mint_public	59.5 (-5%)	10,158
Token:mint_public	50.4 (-10%)	19,034
Token:assert_minter_and_mint	89.9 (+1%)	12,925
AuthRegistry:set_authorized	33.2 (-4%)	7,812
FPC:prepare_fee	103 (-6%)	15,062
Token:transfer_public	⚠️ 26.8 (-30%)	31,218
FPC:pay_refund	133 (+8%)	25,260
Benchmarking:increment_balance	1,321	15,267
Token:_increase_public_balance	64.3 (-1%)	15,006
FPC:pay_refund_with_shielded_rebate	115 (+2%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.6	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.600	0.512	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.9	75.7	132 (+1%)	244	469
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.490	0.465	0.452 (+1%)	0.442	0.439
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.3	111	182	351 (-1%)	693
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.500	0.500	0.483	0.476	0.475
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.517	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,082	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

github-actions · 2024-07-04T18:33:30Z

Changes to circuit sizes

Generated at commit: 17c45fd15575f561c82209848c5c5e4a4f0a0f00, compared to commit: d9cbf4c289d3b3952f84540dadf35e0b410eef2a

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_setup	-1 ✅	-0.00%	-311 ✅	-0.02%
public_kernel_teardown	-1 ✅	-0.00%	-590 ✅	-0.04%
public_kernel_app_logic	-1 ✅	-0.00%	-590 ✅	-0.04%
private_kernel_reset	-16 ✅	-0.01%	-1,381 ✅	-0.08%
private_kernel_tail	-24 ✅	-0.11%	-1,399 ✅	-0.11%
private_kernel_tail_to_public	-771 ✅	-0.17%	-1,899 ✅	-0.11%
private_kernel_reset_big	-16 ✅	-0.02%	-1,381 ✅	-0.11%
private_kernel_reset_medium	-16 ✅	-0.02%	-1,381 ✅	-0.14%
private_kernel_reset_small	-16 ✅	-0.03%	-1,381 ✅	-0.17%
private_kernel_inner	-175 ✅	-0.39%	-2,329 ✅	-0.22%
private_kernel_init	-141 ✅	-0.55%	-933 ✅	-0.25%
private_kernel_init_simulated	0 ➖	0.00%	-8 ✅	-0.36%
private_kernel_inner_simulated	0 ➖	0.00%	-8 ✅	-0.36%
private_kernel_reset_simulated	0 ➖	0.00%	-8 ✅	-0.36%
private_kernel_reset_simulated_big	0 ➖	0.00%	-8 ✅	-0.36%
private_kernel_reset_simulated_medium	0 ➖	0.00%	-8 ✅	-0.36%
private_kernel_reset_simulated_small	0 ➖	0.00%	-8 ✅	-0.36%

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_setup	182,749 (-1)	-0.00%	1,320,011 (-311)	-0.02%
public_kernel_teardown	241,281 (-1)	-0.00%	1,383,928 (-590)	-0.04%
public_kernel_app_logic	241,085 (-1)	-0.00%	1,383,689 (-590)	-0.04%
private_kernel_reset	132,327 (-16)	-0.01%	1,695,461 (-1,381)	-0.08%
private_kernel_tail	21,394 (-24)	-0.11%	1,245,982 (-1,399)	-0.11%
private_kernel_tail_to_public	443,865 (-771)	-0.17%	1,678,810 (-1,899)	-0.11%
private_kernel_reset_big	92,351 (-16)	-0.02%	1,200,029 (-1,381)	-0.11%
private_kernel_reset_medium	72,362 (-16)	-0.02%	952,312 (-1,381)	-0.14%
private_kernel_reset_small	62,367 (-16)	-0.03%	828,493 (-1,381)	-0.17%
private_kernel_inner	44,471 (-175)	-0.39%	1,044,599 (-2,329)	-0.22%
private_kernel_init	25,692 (-141)	-0.55%	379,827 (-933)	-0.25%
private_kernel_init_simulated	1 (0)	0.00%	2,241 (-8)	-0.36%
private_kernel_inner_simulated	1 (0)	0.00%	2,241 (-8)	-0.36%
private_kernel_reset_simulated	1 (0)	0.00%	2,241 (-8)	-0.36%
private_kernel_reset_simulated_big	1 (0)	0.00%	2,241 (-8)	-0.36%
private_kernel_reset_simulated_medium	1 (0)	0.00%	2,241 (-8)	-0.36%
private_kernel_reset_simulated_small	1 (0)	0.00%	2,241 (-8)	-0.36%

LeilaWang · 2024-07-05T11:10:37Z

...ir-protocol-circuits/crates/private-kernel-lib/src/components/private_call_data_validator.nr

-        let first_revertible_index = find_first_revertible_private_call_request_index(public_inputs);
-        // No need to check that the min_revertible_side_effect_counter falls in the counter range of the private call.
-        // It is valid as long as it does not fall in the middle of any nested call.
-        validate_split_ranges(


Moved it down to validate_private_call_requests, which is run by both init and inner. Because now we can set min_revertible_side_effect_counter from any private function, not just the entrypoint. So we need to perform this check when the counter is set.

LeilaWang · 2024-07-05T11:11:45Z

...s/private-kernel-lib/src/tests/private_call_data_validator_builder/validate_as_first_call.nr

@@ -36,101 +17,3 @@ fn validate_as_first_call_delegate_call_fails() {
    let builder = PrivateCallDataValidatorBuilder::new().is_delegate_call();
    builder.validate_as_first_call();
 }
-
-/**
- * Splitting call requests.


Moved the tests tovalidate_private_call_requests.nr

sirasistant

Perfect! 🎉

* master: (176 commits) refactor: counters (#7342) chore: notify Noir team on changes to the stdlib (#7387) chore(bb): do not instantiate Relation (#7389) chore(avm): avoid including flavor where possible (#7361) chore(avm): better log_derivative_inverse_round (#7360) chore(avm): smaller prover (#7359) chore(avm): smaller transcript (#7357) feat: Sync from noir (#7352) feat: VK tree (#6914) chore(docs): Update token tutorial (#7241) chore: sync external contributions (#6984) fix: privacy leak in private refund (#7358) fix: included argshash computation in public call_interfaces and cleanup (#7354) docs: making private refunds smooth-brain friendly (#7343) refactor: optimize public call stack item hashing (#7330) fix: Allow importing notes from other contracts and inject them in the macros (#7349) refactor: Optimize private call stack item hash for gate count (#7285) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits ...

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](#6914)) ([8631237](8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](6137a10)) * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](6137a10)) * TXE docs and usability ([#7305](#7305)) ([6b2a351](6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](6137a10)) * VK tree ([#6914](#6914)) ([8631237](8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](#7349)) ([586c0b0](586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](#7354)) ([13e9b94](13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](6137a10)) * Privacy leak in private refund ([#7358](#7358)) ([e05f6f0](e05f6f0)), closes [#7321](#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) * **docs:** Fix link to docker ([#7395](#7395)) ([ad4a401](ad4a401)) * **docs:** Update token tutorial ([#7241](#7241)) ([0414eb5](0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](6137a10)) * Extracts refactoring of reading error payloads from [#5403](#5403) (noir-lang/noir#5413) ([6137a10](6137a10)) * Generate declaration files for VKs ([#7391](#7391)) ([7c96636](7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](6137a10)) * Notify Noir team on changes to the stdlib ([#7387](#7387)) ([061aac3](061aac3)) * Optimize private call stack item hash for gate count ([#7285](#7285)) ([783d9b6](783d9b6)) * Optimize public call stack item hashing ([#7330](#7330)) ([4a5093c](4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](9eb8d1c)) * Sync external contributions ([#6984](#6984)) ([a265b29](a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](#7343)) ([533c937](533c937)) * Update overview.md (fix link text) ([#7344](#7344)) ([79e5856](79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](#7222)) ### Features * Constant inputs for blackbox ([#7222](#7222)) ([9f9ded2](9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](#7361)) ([dbdffd6](dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](#7360)) ([6329833](6329833)) * **avm:** Smaller prover ([#7359](#7359)) ([7d8c833](7d8c833)) * **avm:** Smaller transcript ([#7357](#7357)) ([3952a44](3952a44)) * **bb:** Do not instantiate Relation ([#7389](#7389)) ([d9cbf4c](d9cbf4c)) * Counters ([#7342](#7342)) ([819f370](819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-package-v0.45.1...aztec-package-v0.46.0) (2024-07-09) ### Features * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) </details> <details><summary>barretenberg.js: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg.js-v0.45.1...barretenberg.js-v0.46.0) (2024-07-09) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>aztec-packages: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@aztec-packages-v0.45.1...aztec-packages-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Add more slice methods to the stdlib (noir-lang/noir#5424) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) * Detect subgraphs that are completely independent from inputs or outputs (noir-lang/noir#5402) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp "go to definition" for modules (noir-lang/noir#5406) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for traits (noir-lang/noir#5409) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp rename/find-all-references for type aliases (noir-lang/noir#5414) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Sync from aztec-packages (noir-lang/noir#5408) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Sync from aztec-packages (noir-lang/noir#5432) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * TXE docs and usability ([#7305](AztecProtocol/aztec-packages#7305)) ([6b2a351](AztecProtocol/aztec-packages@6b2a351)) * Unquote multiple items from annotations (noir-lang/noir#5441) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * VK tree ([#6914](AztecProtocol/aztec-packages#6914)) ([8631237](AztecProtocol/aztec-packages@8631237)) ### Bug Fixes * Allow importing notes from other contracts and inject them in the macros ([#7349](AztecProtocol/aztec-packages#7349)) ([586c0b0](AztecProtocol/aztec-packages@586c0b0)) * Change panic to error in interpreter (noir-lang/noir#5446) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Complete call stacks with no_predicates (noir-lang/noir#5418) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Correct range for overlfowing/underflowing integer assignment (noir-lang/noir#5416) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Included argshash computation in public call_interfaces and cleanup ([#7354](AztecProtocol/aztec-packages#7354)) ([13e9b94](AztecProtocol/aztec-packages@13e9b94)) * Lsp find struct reference in return locations and paths (noir-lang/noir#5404) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Lsp struct rename/reference difference (noir-lang/noir#5411) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Privacy leak in private refund ([#7358](AztecProtocol/aztec-packages#7358)) ([e05f6f0](AztecProtocol/aztec-packages@e05f6f0)), closes [#7321](AztecProtocol/aztec-packages#7321) ### Miscellaneous * Add remaining slice methods to the interpreter (noir-lang/noir#5422) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * Add test and benchmarks for poseidon2 (noir-lang/noir#5386) ([c7b1ae4](AztecProtocol/aztec-packages@c7b1ae4)) * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) * **docs:** Fix link to docker ([#7395](AztecProtocol/aztec-packages#7395)) ([ad4a401](AztecProtocol/aztec-packages@ad4a401)) * **docs:** Update token tutorial ([#7241](AztecProtocol/aztec-packages#7241)) ([0414eb5](AztecProtocol/aztec-packages@0414eb5)) * Dummy workflow (noir-lang/noir#5438) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Extracts refactoring of reading error payloads from [#5403](AztecProtocol/aztec-packages#5403) (noir-lang/noir#5413) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Generate declaration files for VKs ([#7391](AztecProtocol/aztec-packages#7391)) ([7c96636](AztecProtocol/aztec-packages@7c96636)) * Merge `BarretenbergVerifierBackend` and `BarretenbergBackend` (noir-lang/noir#5399) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Move SSA checks to a new folder (noir-lang/noir#5434) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Notify Noir team on changes to the stdlib ([#7387](AztecProtocol/aztec-packages#7387)) ([061aac3](AztecProtocol/aztec-packages@061aac3)) * Optimize private call stack item hash for gate count ([#7285](AztecProtocol/aztec-packages#7285)) ([783d9b6](AztecProtocol/aztec-packages@783d9b6)) * Optimize public call stack item hashing ([#7330](AztecProtocol/aztec-packages#7330)) ([4a5093c](AztecProtocol/aztec-packages@4a5093c)) * Refactor logic around inlining `no_predicates` functions (noir-lang/noir#5433) ([6137a10](AztecProtocol/aztec-packages@6137a10)) * Replace relative paths to noir-protocol-circuits ([8510269](AztecProtocol/aztec-packages@8510269)) * Replace relative paths to noir-protocol-circuits ([9eb8d1c](AztecProtocol/aztec-packages@9eb8d1c)) * Sync external contributions ([#6984](AztecProtocol/aztec-packages#6984)) ([a265b29](AztecProtocol/aztec-packages@a265b29)) ### Documentation * Making private refunds smooth-brain friendly ([#7343](AztecProtocol/aztec-packages#7343)) ([533c937](AztecProtocol/aztec-packages@533c937)) * Update overview.md (fix link text) ([#7344](AztecProtocol/aztec-packages#7344)) ([79e5856](AztecProtocol/aztec-packages@79e5856)) </details> <details><summary>barretenberg: 0.46.0</summary> ## [0.46.0](AztecProtocol/aztec-packages@barretenberg-v0.45.1...barretenberg-v0.46.0) (2024-07-09) ### ⚠ BREAKING CHANGES * constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ### Features * Constant inputs for blackbox ([#7222](AztecProtocol/aztec-packages#7222)) ([9f9ded2](AztecProtocol/aztec-packages@9f9ded2)) ### Miscellaneous * **avm:** Avoid including flavor where possible ([#7361](AztecProtocol/aztec-packages#7361)) ([dbdffd6](AztecProtocol/aztec-packages@dbdffd6)) * **avm:** Better log_derivative_inverse_round ([#7360](AztecProtocol/aztec-packages#7360)) ([6329833](AztecProtocol/aztec-packages@6329833)) * **avm:** Smaller prover ([#7359](AztecProtocol/aztec-packages#7359)) ([7d8c833](AztecProtocol/aztec-packages@7d8c833)) * **avm:** Smaller transcript ([#7357](AztecProtocol/aztec-packages#7357)) ([3952a44](AztecProtocol/aztec-packages@3952a44)) * **bb:** Do not instantiate Relation ([#7389](AztecProtocol/aztec-packages#7389)) ([d9cbf4c](AztecProtocol/aztec-packages@d9cbf4c)) * Counters ([#7342](AztecProtocol/aztec-packages#7342)) ([819f370](AztecProtocol/aztec-packages@819f370)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Enforce min_non_revertible_counter to be set if has public functions.

e75b2f8

LeilaWang added 3 commits July 4, 2024 14:16

Check split private calls for every call.

73ab887

Remove redundant check.

403ce4b

Remove redundant side effect counter in call context.

834202a

LeilaWang added 3 commits July 4, 2024 22:26

Update txe.

00f56e1

Update generated file.

018c58e

Merge remote-tracking branch 'origin/master' into lw/counters

0e757db

LeilaWang commented Jul 5, 2024

View reviewed changes

LeilaWang added 2 commits July 5, 2024 11:17

Update snapshots.

fb8b68f

Check split counter in tail_to_public.

ea73dce

sirasistant approved these changes Jul 8, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into lw/counters

f3b52b3

LeilaWang marked this pull request as ready for review July 8, 2024 15:14

LeilaWang requested review from fcarreiro, dbanks12, jeanmon, IlyasRidhuan and Maddiaa0 as code owners July 8, 2024 15:14

LeilaWang enabled auto-merge (squash) July 8, 2024 15:37

LeilaWang merged commit 819f370 into master Jul 8, 2024
91 checks passed

LeilaWang deleted the lw/counters branch July 8, 2024 15:44

AztecBot mentioned this pull request Jul 8, 2024

chore(master): Release 0.46.0 #7345

Merged

dbanks12 approved these changes Jul 8, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: counters #7342

refactor: counters #7342

LeilaWang commented Jul 4, 2024 •

edited

Loading

AztecBot commented Jul 4, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 4, 2024 •

edited

Loading

LeilaWang Jul 5, 2024

LeilaWang Jul 5, 2024

sirasistant left a comment

refactor: counters #7342

refactor: counters #7342

Conversation

LeilaWang commented Jul 4, 2024 • edited Loading

AztecBot commented Jul 4, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

github-actions bot commented Jul 4, 2024 • edited Loading

Changes to circuit sizes

🧾 Summary (100% most significant diffs)

LeilaWang Jul 5, 2024

Choose a reason for hiding this comment

LeilaWang Jul 5, 2024

Choose a reason for hiding this comment

sirasistant left a comment

Choose a reason for hiding this comment

LeilaWang commented Jul 4, 2024 •

edited

Loading

AztecBot commented Jul 4, 2024 •

edited

Loading

github-actions bot commented Jul 4, 2024 •

edited

Loading