Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Protogalaxy): Move state out of Instances #8177

Merged
merged 17 commits into from
Aug 26, 2024
Merged

Conversation

codygunton
Copy link
Contributor

@codygunton codygunton commented Aug 25, 2024

The main goal of this PR, which is achieved, is to move all move all data except the _data array out of ProverInstances. I do additional cleanup:

  • Use constructors for pow polys rather than a void type function to update the state.
  • Delete commented out higher folding test, which I had been maintaining in commented out form
  • Move ProtogalaxyProofConstructionState def into ProtogalaxyProver
  • More idiomatic folding of relation parameters (loop over a zip of getters)

@codygunton codygunton self-assigned this Aug 25, 2024
@codygunton codygunton changed the base branch from master to cg/pg-state-1 August 25, 2024 07:21
@codygunton codygunton marked this pull request as ready for review August 25, 2024 21:50
@codygunton codygunton changed the title refactor: Clarify state in Protogalaxy 2 refactor(Protogalaxy): Move state out of Instances Aug 25, 2024
Copy link
Contributor

@ledwards2225 ledwards2225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good too

Base automatically changed from cg/pg-state-1 to master August 26, 2024 17:35
@codygunton codygunton merged commit cd5d2df into master Aug 26, 2024
36 checks passed
@codygunton codygunton deleted the cg/pg-state-2 branch August 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants