feat: Stronger typing in L1 contracts #8841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @LHerskind and the rest of your teammates on |
LHerskind
changed the title
Maddiaa0
reviewed
Sep 26, 2024
Maddiaa0
reviewed
Sep 26, 2024
KK68HK
reviewed
Sep 27, 2024
Hej, jeg er ikke helt sikker på hvordan jeg har hjulpet, men glad for at det kunne hjælpe. Hvis du har nogle spørgsmål til koden så sig endelig til og så skal jeg se om jeg kan hjælpe dig. |
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Bumps the solidity version and makes use of the user defined types such that we have `Timestamp`, `Slot` and `Epoch` to make it less likely mixing up these `uint256` that have different "units". Spurred from a timestamp issues, as a slotnumber was passed along and we should be able to make it scream earlier with this. Note that as the types are mostly syntactic sugar and won't make their way all the way down into the abis the errors and selectors should stay the same.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Bumps the solidity version and makes use of the user defined types such that we have `Timestamp`, `Slot` and `Epoch` to make it less likely mixing up these `uint256` that have different "units". Spurred from a timestamp issues, as a slotnumber was passed along and we should be able to make it scream earlier with this. Note that as the types are mostly syntactic sugar and won't make their way all the way down into the abis the errors and selectors should stay the same.
Rumata888
pushed a commit
that referenced
this pull request
Sep 27, 2024
Bumps the solidity version and makes use of the user defined types such that we have `Timestamp`, `Slot` and `Epoch` to make it less likely mixing up these `uint256` that have different "units". Spurred from a timestamp issues, as a slotnumber was passed along and we should be able to make it scream earlier with this. Note that as the types are mostly syntactic sugar and won't make their way all the way down into the abis the errors and selectors should stay the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the solidity version and makes use of the user defined types such that we have
Timestamp,SlotandEpochto make it less likely mixing up theseuint256that have different "units".Spurred from a timestamp issues, as a slotnumber was passed along and we should be able to make it scream earlier with this.
Note that as the types are mostly syntactic sugar and won't make their way all the way down into the abis the errors and selectors should stay the same.