Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: arm build #8870

Merged
merged 7 commits into from
Sep 28, 2024
Merged

fix: arm build #8870

merged 7 commits into from
Sep 28, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 28, 2024

We were improperly trying to reuse x86_64 artifacts on arm64

@ludamad ludamad enabled auto-merge (squash) September 28, 2024 16:20
Copy link
Contributor

github-actions bot commented Sep 28, 2024

Changes to public function bytecode sizes

Generated at commit: 4604e4757ac8ca65dd81b2f3af21a9ad1549056a, compared to commit: 096a0b265f25c843cb7268c0dff25848ae0dabb9

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
NFT::public_dispatch +70 ❌ +0.16%
Token::public_dispatch +112 ❌ +0.15%
FPC::public_dispatch +14 ❌ +0.12%
TokenBridge::public_dispatch +35 ❌ +0.11%
CardGame::public_dispatch +20 ❌ +0.07%
StatefulTest::public_dispatch +7 ❌ +0.05%
TokenBlacklist::public_dispatch +49 ❌ +0.03%
Auth::public_dispatch -14 ✅ -0.04%
AvmTest::public_dispatch -70 ✅ -0.07%
Uniswap::public_dispatch -28 ✅ -0.08%
Lending::public_dispatch -1,440 ✅ -1.65%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
NFT::public_dispatch 43,320 (+70) +0.16%
Token::public_dispatch 72,445 (+112) +0.15%
FPC::public_dispatch 11,393 (+14) +0.12%
TokenBridge::public_dispatch 32,374 (+35) +0.11%
CardGame::public_dispatch 29,762 (+20) +0.07%
StatefulTest::public_dispatch 13,718 (+7) +0.05%
TokenBlacklist::public_dispatch 145,903 (+49) +0.03%
Auth::public_dispatch 33,611 (-14) -0.04%
AvmTest::public_dispatch 97,362 (-70) -0.07%
Uniswap::public_dispatch 33,727 (-28) -0.08%
Lending::public_dispatch 85,669 (-1,440) -1.65%

@ludamad ludamad merged commit e4c5be8 into master Sep 28, 2024
57 checks passed
@ludamad ludamad deleted the ad/fix-arm-build branch September 28, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants