feat: nullable note fields info in ABI #8901
Merged
+96
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
Thunkar
reviewed
Oct 1, 2024
| @@ -15,6 +15,10 @@ use dispatch::generate_public_dispatch; | |||
|
|
|||
| /// Marks a contract as an Aztec contract, generating the interfaces for its functions and notes, as well as injecting | |||
| /// the `compute_note_hash_and_optionally_a_nullifier` function PXE requires in order to validate notes. | |||
| /// | |||
| /// Note: This is a module annotation, so the returned quote gets injected inside the module (contract) itself. | |||
| /// The difference between a module and a regular struct or functionn annotation is that module annotations inject | |||
There was a problem hiding this comment.
The first line of the note is fine, the second one I feel like it's repeating noir docs
There was a problem hiding this comment.
Nuked that in 352f8a1
Thunkar
reviewed
Oct 1, 2024
| @@ -144,14 +148,37 @@ comptime fn generate_note_properties(s: StructDefinition) -> Quoted { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) comptime fn generate_note_export(s: StructDefinition, note_type_id: Field) -> Quoted { | |||
| /// Generates note export for a given note struct. The export is a global variable that contains note type id, | |||
benesjan
force-pushed
the
10-01-feat_nullable_note_fields_info_in_abi
branch
from
6ce30c5
to
352f8a1
Compare
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to robustly position publicly delivered fields in the serialized note array when processing notes we need to know the name of each field, index of where the field starts in the serialized note array and whether the field is nullable/partial.