Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(avm): remove mem accounting from gas #8904

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

fcarreiro
Copy link
Contributor

We are not using it, and it's a required simplification to make relative addressing easier.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

Copy link
Contributor

github-actions bot commented Oct 1, 2024

Changes to public function bytecode sizes

Generated at commit: 7078cdfc374ab11e60a05a182a5fc409d73a4810, compared to commit: ada62205b127c61c2ca81ee74310d089ec560ccb

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
CardGame::public_dispatch +320 ❌ +1.13%
Token::public_dispatch +126 ❌ +0.19%
FPC::public_dispatch +14 ❌ +0.12%
StatefulTest::public_dispatch +14 ❌ +0.11%
TokenBlacklist::public_dispatch -21 ✅ -0.01%
Auth::public_dispatch -21 ✅ -0.06%
NFT::public_dispatch -35 ✅ -0.09%
TokenBridge::public_dispatch -56 ✅ -0.17%
Lending::public_dispatch -1,380 ✅ -1.78%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
CardGame::public_dispatch 28,598 (+320) +1.13%
Token::public_dispatch 67,323 (+126) +0.19%
FPC::public_dispatch 11,393 (+14) +0.12%
StatefulTest::public_dispatch 12,668 (+14) +0.11%
TokenBlacklist::public_dispatch 141,137 (-21) -0.01%
Auth::public_dispatch 33,604 (-21) -0.06%
NFT::public_dispatch 40,352 (-35) -0.09%
TokenBridge::public_dispatch 32,339 (-56) -0.17%
Lending::public_dispatch 76,130 (-1,380) -1.78%

@fcarreiro fcarreiro merged commit 38b485e into master Oct 1, 2024
53 checks passed
Copy link
Contributor Author

Merge activity

@fcarreiro fcarreiro deleted the fc/avm-remove-mem-from-gas branch October 1, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants