feat: bb.js tests of ClientIVC #9412
Conversation
codygunton
force-pushed
the
cg/browser-civc
branch
from
24be2f4
to
b37445a
Compare
codygunton
force-pushed
the
cg/browser-civc
branch
from
149342a
to
300f3d6
Compare
codygunton
force-pushed
the
cg/browser-civc
branch
from
300f3d6
to
cab6cbb
Compare
codygunton
force-pushed
the
cg/browser-civc
branch
from
6f7e5c9
to
51441ff
Compare
| } | ||
| }, | ||
| { | ||
| "name": "wasm-threads-assert", |
There was a problem hiding this comment.
Added asserts build for wasm, much faster to build than dbg. Considered making it the default but idk, might affect performance if we use heavy asserts.
| ivc.auto_verify_mode = true; | ||
| ivc.trace_structure = TraceStructure::E2E_FULL_TEST; | ||
|
|
||
| // Accumulate the entire program stack into the IVC |
There was a problem hiding this comment.
Just carrying along this todo bc this second was basically a copy and paste from main.cpp.
| @@ -545,6 +545,18 @@ export class BarretenbergApi { | |||
| return out as any; | |||
| } | |||
|
|
|||
| async acirProveAndVerifyAztecClient(acirVec: Uint8Array[], witnessVec: Uint8Array[]): Promise<boolean> { | |||
There was a problem hiding this comment.
We don't need separate prove and verify flows yet. My goal is to get something measurable, someone can easily follow the pattern to add these in the future.
There was a problem hiding this comment.
Also we don't ever want a verify flow through wasm. Prob we should star to cut stuff out of the wasm binary since it's already large.
There was a problem hiding this comment.
Did you add this by hand? Just checking as this file is code generated by the bindgen util.
| @@ -0,0 +1,17 @@ | |||
| { | |||
There was a problem hiding this comment.
FYI the browser test does not need a running server to execute. But I do add a a webpage as in browser test app to serve the app for execution in a browser bc I want to be able to use the browser's built in profiling and debugging tools.
| @@ -1,13 +1,7 @@ | |||
| import { BB_RESULT, executeBbClientIvcProof, verifyClientIvcProof } from '@aztec/bb-prover'; | |||
| import { ClientIvcProof } from '@aztec/circuits.js'; | |||
| import { createDebugLogger } from '@aztec/foundation/log'; | |||
|
|
|||
| import { jest } from '@jest/globals'; | |||
There was a problem hiding this comment.
There are now three tests that tests the same circuits: the native version, this 'wasm' version that uses bb.js as a library' and a browser version that executes through playwright. Prob we don't need all three, your call.
| @@ -691,6 +691,7 @@ __metadata: | |||
| resolution: "@aztec/ivc-integration@workspace:ivc-integration" | |||
| dependencies: | |||
| "@aztec/bb-prover": "workspace:^" | |||
| "@aztec/bb.js": ../../ts | |||
There was a problem hiding this comment.
Idk how to not have a huge diff here.
| @@ -545,6 +545,18 @@ export class BarretenbergApi { | |||
| return out as any; | |||
| } | |||
|
|
|||
| async acirProveAndVerifyAztecClient(acirVec: Uint8Array[], witnessVec: Uint8Array[]): Promise<boolean> { | |||
There was a problem hiding this comment.
Did you add this by hand? Just checking as this file is code generated by the bindgen util.
| const [bytecodes, witnessStack] = await generate6FunctionTestingIVCStack(); | ||
|
|
||
| logger(`calling prove and verify...`); | ||
| const verifyResult = await proveAndVerifyAztecClient(page, bytecodes, witnessStack); |
There was a problem hiding this comment.
I think this just executes the exposed function in Node - so I don't think this is actually executing in the browser.
That's why I had an actual server serve a page in the acir_tests.
I can see you do actually have a webpack bundled page below - so I think you just need to change this test to load that page (assuming served on e.g. localhost:8080) and then evaluate a call that clicks the button (or calls the function in the page exposed on the window, think thats what i did in my acir_tests).
I guess the faff from CI perspective is you need a wrapper script that does the webpack serve or whatever to start the server, before running the jest test.
This reverts commit 542cf8f.
codygunton
changed the title
Extend the ivc-integration-tests suite to execute tests through bb.js, but using bb.js as a library and via the browser. When run, these tests give both memory and time logs. We should make these easier to read, but for now they're very useful. Note that, for now, the browser version of the tests are not run in CI because yarn build:browser hangs in that context.