Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra number from return type of acirGetCircuitSizes #9493

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

TomAFrench
Copy link
Member

Due to the use of any we're returning a Promise<[number, number]> in a function which has the return type of Promise<[number, number, number]>

Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 576881acab239ddd3f92d31045a9b8b9778d31b7, compared to commit: 078c318f9671566500c472553d88990076a8c32a

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::bulk_testing +1,981 ❌ +9.31%
AvmTest::public_dispatch -459 ✅ -0.83%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::bulk_testing 23,248 (+1,981) +9.31%
AvmTest::public_dispatch 55,100 (-459) -0.83%

Copy link
Contributor

@aakoshh aakoshh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TypeScript is so malleable 👍

@TomAFrench TomAFrench merged commit 1aef553 into master Nov 1, 2024
58 checks passed
@TomAFrench TomAFrench deleted the tf/fix-types-on-acirGetCircuitSizes branch November 1, 2024 13:50
@lucasxia01
Copy link
Contributor

oh whoops, I must have missed this, thanks for fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants