Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle direct memory tag checks and raise operation error #9745

Closed
jeanmon opened this issue Nov 5, 2024 · 0 comments · Fixed by #9831
Closed

Handle direct memory tag checks and raise operation error #9745

jeanmon opened this issue Nov 5, 2024 · 0 comments · Fixed by #9831
Assignees
@jeanmon
Labels
C-avm Component: AVM related tickets (aka public VM)
Milestone
TestNet

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Nov 5, 2024 •
edited
Loading

This task is twofold:

  1. Raise op_err whenever tag_err is raised and stop execution.
  2. Add comprehensive (not necessarily constrained) tag checking for all the opcodes:
    • SHR and SHL where one operand must be of type U8
@jeanmon jeanmon self-assigned this Nov 5, 2024
@jeanmon jeanmon added the C-avm Component: AVM related tickets (aka public VM) label Nov 5, 2024
@jeanmon jeanmon added this to the TestNet milestone Nov 5, 2024
@jeanmon jeanmon added this to A3 Nov 5, 2024
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 5, 2024
@jeanmon jeanmon moved this from Todo to In Progress in A3 Nov 5, 2024
@jeanmon jeanmon mentioned this issue Nov 8, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Nov 12, 2024
@AztecBot AztecBot mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
A3
Status: Done
Milestone
TestNet
Development

Successfully merging a pull request may close this issue.

feat(avm): tag checking, raising errors and stop execution AztecProtocol/aztec-packages
1 participant
@jeanmon